Skip to content

SPLAT-2794: Create OTE Binary and add vSphere hybrid e2e tests#471

Open
vr4manta wants to merge 2 commits into
openshift:release-4.22from
vr4manta:SPLAT-2794
Open

SPLAT-2794: Create OTE Binary and add vSphere hybrid e2e tests#471
vr4manta wants to merge 2 commits into
openshift:release-4.22from
vr4manta:SPLAT-2794

Conversation

@vr4manta

@vr4manta vr4manta commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

SPLAT-2794

Changes

  • Created OTE binary
  • Added vSphere hybrid env e2e tests

Notes

This PR does not refactor the upstream aws ccm e2e changes. For 4.22 I am leaving them alone to prevent any interference with its stability. In 5.0, this was moved into the openshift-tests directory and custom go.mod controls were introduced to prevent any dependency issues when pulling changes from upstream.

For the OTE to execute during CI, we will still need to update origin to include this binary for the 4.22 builds.
openshift/origin#31303

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 15, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 15, 2026

Copy link
Copy Markdown

@vr4manta: This pull request references SPLAT-2794 which is a valid jira issue.

Details

In response to this:

SPLAT-2794

Changes

  • Created OTE binary
  • Added vSphere hybrid env e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: bff81a6c-f9df-4b2d-a506-b527a2b4d81f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2026
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vr4manta

Copy link
Copy Markdown
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-hybrid-env-techpreview openshift/origin#31303

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-hybrid-env-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/20301940-68d2-11f1-85e8-271c25976bd8-0

@vr4manta

Copy link
Copy Markdown
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-hybrid-env-techpreview openshift/origin#31303

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-hybrid-env-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e9cb4960-68d6-11f1-9324-754438e212bb-0

@vr4manta vr4manta marked this pull request as ready for review June 15, 2026 17:14
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2026
@vr4manta

Copy link
Copy Markdown
Contributor Author

/hold
Attempting to do payload job for complete test

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2026
@openshift-ci openshift-ci Bot requested review from RadekManak and nrb June 15, 2026 17:15
@vr4manta vr4manta force-pushed the SPLAT-2794 branch 2 times, most recently from adb8212 to 5c969f5 Compare June 15, 2026 18:34
@vr4manta

Copy link
Copy Markdown
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-hybrid-env-techpreview openshift/origin#31303

@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-hybrid-env-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6ae0e740-698f-11f1-9059-2e224b650e91-0

@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vr4manta

Copy link
Copy Markdown
Contributor Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2026
@vr4manta

Copy link
Copy Markdown
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-hybrid-env-techpreview openshift/origin#31303

@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-hybrid-env-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fb401660-69be-11f1-954b-2036b46d4055-0

@vr4manta

Copy link
Copy Markdown
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-hybrid-env-techpreview openshift/origin#31303

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-hybrid-env-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2358e880-6a3b-11f1-9754-9355acf59ad9-0

@vr4manta

Copy link
Copy Markdown
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-hybrid-env-techpreview openshift/origin#31303

@openshift-ci

openshift-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-hybrid-env-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/497292d0-6b05-11f1-8161-670e9b7a11ab-0

@vr4manta

Copy link
Copy Markdown
Contributor Author

Payload-job ran and succeeded above. In there we can see the two new e2e's run and completed successfully.

started: 0/177/530 "[OCPFeatureGate:VSphereMixedNodeEnv][platform:vsphere][Suite:openshift/conformance/parallel] vSphere hybrid environment should apply platform-type label to nodes"
passed: (100ms) 2026-06-18T13:18:04 "[OCPFeatureGate:VSphereMixedNodeEnv][platform:vsphere][Suite:openshift/conformance/parallel] vSphere hybrid environment should apply platform-type label to nodes"
started: 0/511/530 "[OCPFeatureGate:VSphereMixedNodeEnv][platform:vsphere][Suite:openshift/conformance/parallel] vSphere hybrid environment should have --node-labels parameter in cloud-controller-manager pod"
passed: (0s) 2026-06-18T13:22:06 "[OCPFeatureGate:VSphereMixedNodeEnv][platform:vsphere][Suite:openshift/conformance/parallel] vSphere hybrid environment should have --node-labels parameter in cloud-controller-manager pod"

@nrb

nrb commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

/approve
/label backport-risk-assessed
/verified by updated payload jobs including the target tests

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 18, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@nrb: This PR has been marked as verified by updated payload jobs including the target tests.

Details

In response to this:

/approve
/label backport-risk-assessed
/verified by updated payload jobs including the target tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants