Skip to content

SRVKP-14105: rerender pipeline topology for parent pl - #1326

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-pipelines:masterfrom
anwesha-palit-redhat:feat/SRVKP-14105
Sep 2, 2026
Merged

SRVKP-14105: rerender pipeline topology for parent pl#1326
openshift-merge-bot[bot] merged 1 commit into
openshift-pipelines:masterfrom
anwesha-palit-redhat:feat/SRVKP-14105

Conversation

@anwesha-palit-redhat

Copy link
Copy Markdown
Contributor

Type of Change

  • Bug fix
  • New feature
  • Refactoring
  • Migration
  • CVE Fix

Summary

Screen Recordings / Screenshot

rerenderpipelinetopology.mov

@openshift-ci-robot

openshift-ci-robot commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

@anwesha-palit-redhat: This pull request references SRVKP-14105 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Type of Change

  • Bug fix
  • New feature
  • Refactoring
  • Migration
  • CVE Fix

Summary

Screen Recordings / Screenshot

rerenderpipelinetopology.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested a review from ankrsinha September 2, 2026 11:00
@openshift-ci openshift-ci Bot added the approved Label for Approved PRs label Sep 2, 2026
@anwesha-palit-redhat anwesha-palit-redhat removed the approved Label for Approved PRs label Sep 2, 2026
@anwesha-palit-redhat

Copy link
Copy Markdown
Contributor Author

/agentic_describe

@qodo-code-review

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Warning

/review is deprecated. Use /agentic_review instead (removal date not yet scheduled).

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@anwesha-palit-redhat
anwesha-palit-redhat removed the request for review from ankrsinha September 2, 2026 11:01

@arvindk-softwaredev arvindk-softwaredev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Looks Good to Me Label label Sep 2, 2026
@openshift-ci

openshift-ci Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anwesha-palit-redhat, arvindk-softwaredev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [anwesha-palit-redhat,arvindk-softwaredev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Label for Approved PRs label Sep 2, 2026
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Remount topology when the parent pipeline changes

🐞 Bug fix 🕐 Less than 5 minutes

Grey Divider

AI Description

• Remounts the topology graph when the displayed pipeline UID changes.
• Prevents stale child topology when returning to a parent pipeline.
Diagram

graph TD
  A["Pipeline selection"] --> B["Pipeline visualization"] --> C{"UID changed?"}
  C -- "Yes" --> D["Remount graph"] --> E["Fresh topology"]
  C -- "No" --> F["Reuse graph"]
Loading
High-Level Assessment

Using the pipeline UID as the graph key is the most focused approach because pipeline identity changes should reset topology-local state. Explicitly resetting the visualization controller was considered but would add lifecycle complexity for the same result.

Files changed (1) +1 / -0

Bug fix (1) +1 / -0
PipelineVisualization.tsxKey topology graphs by pipeline UID +1/-0

Key topology graphs by pipeline UID

• Adds the pipeline UID as the React key for 'PipelineTopologyGraph'. Changing between parent and child pipelines now remounts the graph and prevents stale topology state from persisting.

src/components/pipelines-details/PipelineVisualization.tsx

@openshift-merge-bot
openshift-merge-bot Bot merged commit b00359e into openshift-pipelines:master Sep 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Label for Approved PRs Bug fix jira/valid-reference lgtm Looks Good to Me Label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants