Bump github.com/openshift-online/ocm-sdk-go from 0.1.488 to 0.1.494#1010
Bump github.com/openshift-online/ocm-sdk-go from 0.1.488 to 0.1.494#1010dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthroughgo.mod dependency bumps: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@go.mod`:
- Line 20: The code calls removed/changed SDK fields (ScheduleType(), NextRun(),
Schedule(), UpgradeType(), EnableMinorVersionUpgrades(), ProvisionShard(),
HiveConfig(), ManagementCluster(), HypershiftConfig(),
AWSAccountOperatorConfig(), GCPProjectOperator(), AWSBaseDomain()) and must be
updated to the new ocm‑sdk-go API; replace usages of those getters with the new
equivalents from v0.1.494 (use the new UpgradePolicy/ProvisionShard struct
fields or accessors provided by the SDK), remove or guard code that relied on
removed fields, and ensure ProvisionShard.Topology is set to or validated as
"shared" per the new required constraint; update the call sites that referenced
ScheduleType()/NextRun() and the ProvisionShard related methods to use the SDK's
current methods/fields and add necessary nil/variant checks so the code compiles
against v0.1.494.
go.mod
Outdated
| github.com/onsi/gomega v1.38.3 | ||
| github.com/openshift-online/ocm-common v0.0.34 | ||
| github.com/openshift-online/ocm-sdk-go v0.1.488 | ||
| github.com/openshift-online/ocm-sdk-go v0.1.494 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# 1. Check the go.mod file around the mentioned lines
echo "=== go.mod dependencies ==="
cat -n go.mod | sed -n '15,30p'
echo ""
echo "=== Lines 120-130 for indirect dependencies ==="
cat -n go.mod | sed -n '120,130p'Repository: openshift-online/ocm-cli
Length of output: 1664
🏁 Script executed:
#!/bin/bash
# 2. Run the verification script to scan for usage of removed fields
rg -n -C3 --type=go -g '!**/vendor/**' \
-e '\bScheduleType\b|\bUpgradeType\b|\bNextRun\b|\bEnableMinorVersionUpgrades\b' \
-e '\bHypershiftConfig\b|\bManagementCluster\b|\bHiveConfig\b|\bAWSAccountOperatorConfig\b|\bGCPProjectOperator\b|\bAWSBaseDomain\b' \
-e '\bProvisionShard\b|\bAzureShard\b|\bProvisionShardMaestroConfig\b'Repository: openshift-online/ocm-cli
Length of output: 3036
🏁 Script executed:
#!/bin/bash
# 3. Check repository structure and look for any codebase that imports ocm-sdk
echo "=== Repository structure ==="
ls -la
echo ""
echo "=== Looking for Go files that might use ocm-sdk ==="
fd --type f '\.go$' -g '!vendor' | head -20Repository: openshift-online/ocm-cli
Length of output: 1636
🏁 Script executed:
#!/bin/bash
# Check git history to understand context of this dependency bump
echo "=== Recent commits mentioning ocm-sdk ==="
git log --oneline --all -20 | grep -i "sdk\|upgrade\|provision"
echo ""
echo "=== Check if there's any migration or adaptation in recent commits ==="
git log --oneline -p -- "cmd/ocm/create/upgradepolicy/cmd.go" "pkg/cluster/describe.go" | head -100Repository: openshift-online/ocm-cli
Length of output: 3244
🌐 Web query:
ocm-sdk-go v0.1.494 release notes changelog removals
💡 Result:
ocm-sdk-go v0.1.494 release notes (released Feb 12, 2026) include the following removals:
- ARO-HCP upgrade policy types: removed scheduling-related fields:
Schedule,ScheduleType,UpgradeType,NextRun,EnableMinorVersionUpgrades(as part of “Simplify ARO-HCP upgrade policy types”). [1]
Source: GitHub release “Release 0.1.494”. [1]
References
🌐 Web query:
ocm-sdk-go v0.1.489 to v0.1.494 breaking changes ScheduleType NextRun ProvisionShard
💡 Result:
Between ocm-sdk-go v0.1.489 → v0.1.494, the breaking changes related to ScheduleType / NextRun / ProvisionShard are:
-
v0.1.494 (Feb 12, 2026): breaking removal of scheduling fields from ARO-HCP upgrade policy types
- Removed scheduling-related fields:
Schedule,ScheduleType,UpgradeType,NextRun,EnableMinorVersionUpgrades. - If your code referenced any of these fields on the ARO-HCP upgrade policy types, you must delete/update those references. [1]
- Removed scheduling-related fields:
-
v0.1.492: ProvisionShard now requires
Topologyand restricts its valueProvisionShard.Topologybecame required, and allowed value is restricted toshared.- If you construct
ProvisionShardobjects, ensure you always setTopology(and toshared). [1]
-
v0.1.491: ProvisionShard field removals (ARO-HCP)
- Removed from ARO-HCP
ProvisionShard:HypershiftConfig,ManagementCluster,HiveConfig,AWSAccountOperatorConfig,GCPProjectOperator,AWSBaseDomain(listed twice in changelog). - Added:
AzureShardandProvisionShardMaestroConfig. [1]
- Removed from ARO-HCP
Non-breaking but relevant:
- v0.1.493 added/exposed ARO-HCP provision shard GET endpoints (subresource + global endpoints). [1]
Source: ocm-sdk-go CHANGES.md. [1]
Code uses fields removed/changed in ocm-sdk-go v0.1.494—this will fail to compile.
Release notes confirm breaking removals:
- v0.1.494 removed upgrade policy fields:
ScheduleType,NextRun,Schedule,UpgradeType,EnableMinorVersionUpgrades - v0.1.491 removed ProvisionShard fields:
HiveConfig,ManagementCluster,HypershiftConfig,AWSAccountOperatorConfig,GCPProjectOperator,AWSBaseDomain - v0.1.492 made
ProvisionShard.Topologyrequired (restricted to"shared")
Codebase actively references these removed fields:
cmd/ocm/create/upgradepolicy/cmd.golines 153, 226–227 callScheduleType()andNextRun()cmd/ocm/list/upgradepolicy/cmd.golines 104, 106 callScheduleType()andNextRun()pkg/cluster/describe.golines 111–116 callProvisionShard(),HiveConfig(), and line 372 callsManagementCluster()
Update all call sites to use the updated SDK API before merging.
🤖 Prompt for AI Agents
In `@go.mod` at line 20, The code calls removed/changed SDK fields
(ScheduleType(), NextRun(), Schedule(), UpgradeType(),
EnableMinorVersionUpgrades(), ProvisionShard(), HiveConfig(),
ManagementCluster(), HypershiftConfig(), AWSAccountOperatorConfig(),
GCPProjectOperator(), AWSBaseDomain()) and must be updated to the new ocm‑sdk-go
API; replace usages of those getters with the new equivalents from v0.1.494 (use
the new UpgradePolicy/ProvisionShard struct fields or accessors provided by the
SDK), remove or guard code that relied on removed fields, and ensure
ProvisionShard.Topology is set to or validated as "shared" per the new required
constraint; update the call sites that referenced ScheduleType()/NextRun() and
the ProvisionShard related methods to use the SDK's current methods/fields and
add necessary nil/variant checks so the code compiles against v0.1.494.
|
rebase DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Bumps [github.com/openshift-online/ocm-sdk-go](https://github.com/openshift-online/ocm-sdk-go) from 0.1.488 to 0.1.494. - [Release notes](https://github.com/openshift-online/ocm-sdk-go/releases) - [Changelog](https://github.com/openshift-online/ocm-sdk-go/blob/main/CHANGES.md) - [Commits](openshift-online/ocm-sdk-go@v0.1.488...v0.1.494) --- updated-dependencies: - dependency-name: github.com/openshift-online/ocm-sdk-go dependency-version: 0.1.494 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
b981af0 to
3474c9d
Compare
|
Superseded by #1026. |
Bumps github.com/openshift-online/ocm-sdk-go from 0.1.488 to 0.1.494.
Release notes
Sourced from github.com/openshift-online/ocm-sdk-go's releases.
Changelog
Sourced from github.com/openshift-online/ocm-sdk-go's changelog.
Commits
f9a302dMerge pull request #1137 from machi1990/prepare-release-0.1.4948ef1a7fchore: prepare next release 0.1.4942346f05Merge pull request #1136 from machi1990/bump/model-to-0.0.44907833a8chore: update ocm api model to v0.0.44905bcb7fMerge pull request #1134 from zgalor/release-0.1.49386d0037chore: Release v0.1.49386d01ebMerge pull request #1133 from zgalor/update-ocmapimodel-v004486ff9fa9chore: update ocm api model to v0.0.448690e5d5Merge pull request #1131 from miguelsorianod/release-0.1.492a866becchore: Release v0.1.492Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)