Bump github.com/onsi/ginkgo/v2 from 2.27.5 to 2.28.1#1001
Bump github.com/onsi/ginkgo/v2 from 2.27.5 to 2.28.1#1001dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughUpdated dependency versions in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@go.mod`:
- Line 97: The pprof module was bumped to v0.0.0-20260115054156-294ebfa9ad83
which requires Go 1.24.9+; update the project's minimum Go version to at least
1.24.9 by changing the go directive in go.mod (the "go" version) and ensure
CI/workflow configurations that set the Go toolchain (e.g., GitHub Actions,
Makefile, or Dockerfiles) are adjusted to use Go 1.24.9 or newer so tests and
builds won't fail due to the Go 1.24.8 bug.
- Around line 17-18: The go.mod Go version (go 1.24.6) is inconsistent with the
CI test runner (Go 1.22); either update CI to run Go 1.24.x or lower the go
directive in go.mod to match CI (e.g., change to go 1.22) so versions align.
Confirm gomega v1.39.0 and ginkgo v2.28.1 work with the chosen Go version, and
then update the go.mod "go" line and/or the CI workflow Go version accordingly,
rerun tests, and commit the change to keep go.mod (go 1.24.6), ginkgo v2.28.1,
and gomega v1.39.0 consistent with CI.
| github.com/onsi/ginkgo/v2 v2.28.1 | ||
| github.com/onsi/gomega v1.39.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Ginkgo v2.28.1 release notes Go version requirement
💡 Result:
Web search failed: Server error: no LLM provider could handle the message
🌐 Web query:
Gomega v1.39.0 release notes Go version requirement
💡 Result:
Gomega v1.39.0 did not change the Go version requirement; it remained at Go 1.23 (the prior release v1.38.2 explicitly “roll[ed] back to go 1.23.0”, and the Go requirement bump to Go 1.24 only appears in v1.39.1 release notes). [1]
Source: onsi/gomega GitHub Releases page. [1]
🌐 Web query:
Ginkgo v2.28.1 minimum Go version compatibility requirements
💡 Result:
Web search failed: Server error: no LLM provider could handle the message
🏁 Script executed:
# Check for CI/toolchain configuration files
git ls-files | grep -E '(\.github/|\.gitlab|\.circleci|go\.mod|go\.sum|Makefile|\.tool-versions)' | head -20Repository: openshift-online/ocm-cli
Length of output: 229
🏁 Script executed:
# Check GitHub workflow for Go version used in CI
cat .github/workflows/check-pull-request.yaml | head -80Repository: openshift-online/ocm-cli
Length of output: 2188
🏁 Script executed:
# Check go.mod for any comments or full dependency details
cat -n go.modRepository: openshift-online/ocm-cli
Length of output: 9810
Reconcile CI/toolchain Go version mismatch with go.mod declaration.
The test job in CI runs on Go 1.22 (.github/workflows/check-pull-request.yaml, line 47), while go.mod declares Go 1.24.6. Gomega v1.39.0 requires only Go 1.23 minimum, so verify that ginkgo v2.28.1 is compatible with the declared minimum Go version and that CI is updated to test against it.
🤖 Prompt for AI Agents
In `@go.mod` around lines 17 - 18, The go.mod Go version (go 1.24.6) is
inconsistent with the CI test runner (Go 1.22); either update CI to run Go
1.24.x or lower the go directive in go.mod to match CI (e.g., change to go 1.22)
so versions align. Confirm gomega v1.39.0 and ginkgo v2.28.1 work with the
chosen Go version, and then update the go.mod "go" line and/or the CI workflow
Go version accordingly, rerun tests, and commit the change to keep go.mod (go
1.24.6), ginkgo v2.28.1, and gomega v1.39.0 consistent with CI.
| github.com/gogo/protobuf v1.3.2 // indirect | ||
| github.com/google/go-cmp v0.7.0 // indirect | ||
| github.com/google/pprof v0.0.0-20251206212654-f1b79c6b8239 // indirect | ||
| github.com/google/pprof v0.0.0-20260115054156-294ebfa9ad83 // indirect |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
github.com/google/pprof v0.0.0-20260115054156 security advisories CVE
💡 Result:
For github.com/google/pprof at v0.0.0-20260115054156-294ebfa9ad83 (your pseudo-version; commit shown in Go’s vendored modules.txt) there are no published GitHub Security Advisories, and therefore no CVEs are currently associated via the upstream google/pprof repo’s advisory feed. [2][1]
🌐 Web query:
github.com/google/pprof January 2026 release notes compatibility Go version
💡 Result:
- GitHub “release notes” (Jan 2026): The
google/pprofrepo does not publish GitHub Releases (“No releases published”), so there aren’t official January 2026 “release notes” in the Releases UI. [1] - What changed around January 2026 (based on commits):
- Jan 11, 2026: “allow compatibility with go 1.24.0”. [2]
- Dec 7, 2025 → carried into Jan 2026 mainline: “Require at least 1.24.9” (because Go 1.24.8 had a bug causing test failures). [3]
- Jan 15, 2026 (main): repo state includes maintenance updates like golangci-lint update (commit shown as Jan 15, 2026 in the mirror). [4]
- Go version compatibility (as of that Jan 2026 mainline state):
- The module’s
go.moddeclaresgo 1.24.9, and the project explicitly raised the minimum to Go 1.24.9+ due to the Go 1.24.8 bug. [5] [3]
- The module’s
- Which pprof version Go itself picked up in Jan 2026: The Go repo updated its vendored
github.com/google/pproftov0.0.0-20260115054156-294ebfa9ad83. [6]
Sources: [1] [2] [3] [4] [5] [6]
Ensure Go 1.24.9+ compatibility for pprof update.
This pprof version requires Go 1.24.9 or later (due to a bug in Go 1.24.8 that causes test failures). No security advisories are associated with this update, but verify the project's minimum Go version supports 1.24.9+.
🤖 Prompt for AI Agents
In `@go.mod` at line 97, The pprof module was bumped to
v0.0.0-20260115054156-294ebfa9ad83 which requires Go 1.24.9+; update the
project's minimum Go version to at least 1.24.9 by changing the go directive in
go.mod (the "go" version) and ensure CI/workflow configurations that set the Go
toolchain (e.g., GitHub Actions, Makefile, or Dockerfiles) are adjusted to use
Go 1.24.9 or newer so tests and builds won't fail due to the Go 1.24.8 bug.
|
rebase DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8f8d4a3 to
30c39c9
Compare
|
rebase DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.27.5 to 2.28.1. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.27.5...v2.28.1) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-version: 2.28.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
30c39c9 to
c2a4bd3
Compare
Bumps github.com/onsi/ginkgo/v2 from 2.27.5 to 2.28.1.
Release notes
Sourced from github.com/onsi/ginkgo/v2's releases.
Changelog
Sourced from github.com/onsi/ginkgo/v2's changelog.
Commits
5d1d628v2.28.1676f985update test mu language8032100appease go vet41ca807bump dependencies2b2305bv2.28.071d2d89feat: support component semantic version filtering8cbbcb4Fix doclink for ginkgo runDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)