Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 95.79% 95.66% -0.14%
==========================================
Files 23 24 +1
Lines 2069 2189 +120
Branches 388 409 +21
==========================================
+ Hits 1982 2094 +112
- Misses 69 77 +8
Partials 18 18
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Initial cut of a
RemoteDatasetclass for handling API-based queries. Haven't written any docs yet, but looking for some feedback on naming/structure etc.The added notebook contains examples of the use of the class so that might be a good place to start
Please confirm that this pull request has done the following:
CHANGELOG.rstaddedSee https://github.com/openscm/scmdata/pull/198/files/b76adbb979527cc5932cbb563ff53e98439372c8..05401af873aa00871777255382b36cc33c5ef855 for a summary of the changes