Implement run benchmark UI by cezudas · Pull Request #2041 · openops-cloud/openops

cezudas · 2026-03-02T17:31:01Z

https://www.loom.com/share/7558a94cd14d4c7db878e3195b2ff5d9

flow-rows → orchestrator-filter → run-fetch pipeline, leaving listBenchmarks as three sequential, decoupled steps.

linear · 2026-03-02T17:31:05Z

Copilot

Pull request overview

Implements the “run benchmark” UX in the benchmark wizard by adding a run/polling hook, wiring footer actions (run/view/reset), and exposing running progress in the UI components.

Changes:

Add useBenchmarkRun hook to trigger benchmark runs, poll status, and compute per-workflow progress.
Update benchmark wizard + footer to support “Run now”, disable setup changes while running, and show failed-state actions.
Update UI components/stories for running progress and analytics link parameterization.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
packages/ui-components/src/stories/benchmark/benchmark-ready-step.stories.tsx	Updates story args to include webhook payload/provider and adds a “running with progress” state.
packages/ui-components/src/components/benchmark/benchmark-running-phase.tsx	Adds optional progress rendering in the running phase UI.
packages/ui-components/src/components/benchmark/benchmark-ready-step.tsx	Plumbs running progress into the running phase; removes failed-phase action callbacks.
packages/ui-components/src/components/benchmark/benchmark-failed-phase.tsx	Simplifies failed phase to message-only (actions moved to wizard footer).
packages/ui-components/src/components/benchmark/benchmark-analytics-phase.tsx	Updates analytics link query param to `dashboard=..._benchmark`.
packages/react-ui/src/app/features/benchmark/use-benchmark-run.ts	New hook for run trigger, status polling, lastRunId tracking, and progress computation.
packages/react-ui/src/app/features/benchmark/tests/use-benchmark-run.test.ts	Adds unit tests covering run trigger, polling phase transitions, reset, and progress counts.
packages/react-ui/src/app/features/benchmark/components/view-benchmark-workflows-button.tsx	Adds `disabled` prop to prevent navigation while a run is active.
packages/react-ui/src/app/features/benchmark/components/benchmark-wizard.tsx	Integrates `useBenchmarkRun`, adds “view run” navigation, resets run when editing setup, passes progress to UI.
packages/react-ui/src/app/features/benchmark/components/benchmark-wizard-footer.tsx	Adds run-phase-aware footer actions (run now / view run / run again) and disables controls while running.
packages/react-ui/src/app/features/benchmark/benchmark-api.ts	Adds API methods to run benchmark via webhook, fetch status, and list benchmarks.
packages/react-ui/src/app/constants/query-keys.ts	Adds `benchmarkStatus` query key constant.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/react-ui/src/app/features/benchmark/use-benchmark-run.ts

Copilot · 2026-03-03T13:04:28Z

packages/react-ui/src/app/features/benchmark/components/benchmark-wizard-footer.tsx

+        <Button
+          size="sm"
+          disabled={!hasOrchestrator || isRunning}
+          onClick={onRunNow}
+        >
          {t('Run now')}
        </Button>


onRunNow returns a Promise, but it’s passed directly to Button’s onClick. If the mutation rejects, this can surface as an unhandled promise rejection in the browser since the click handler isn’t awaited/caught. Wrap the call in a sync handler that catches (or ensure onRunNow never rejects) so failures are handled cleanly.

Copilot · 2026-03-03T13:04:28Z

packages/ui-components/src/components/benchmark/benchmark-running-phase.tsx

+          {`${t('— Running workflows')} ${progress.completed}/${
+            progress.total
+          }...`}


The progress text is built by concatenating a translated fragment with numbers/punctuation inside a template string. For i18n, it’s safer to translate the full sentence with interpolation (e.g. completed/total) so languages can reorder tokens and punctuation correctly.

Suggested change

{`${t('— Running workflows')} ${progress.completed}/${

progress.total

}...`}

{t('— Running workflows {{completed}}/{{total}}...', {

completed: progress.completed,

total: progress.total,

})}

Unfortunately, While react-ui i18n setup supports the full sentence with interpolation, Storybook i18n setup does not support it.

packages/react-ui/src/app/features/benchmark/components/benchmark-wizard.tsx

packages/react-ui/src/app/features/benchmark/use-benchmark-run.ts

alexandrudanpop · 2026-03-03T15:29:30Z

I see some issues on the UX side, that would be good to address:

The final link to Analytics does not look as a CTA, but more like a secondary action. Also, the copy does not tell what you will see. I think something better would be View Results.

In this final stage, the Run now button looks like the main CTA. This might be called Run again instead, with a secondary button variation.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…rent step

cezudas · 2026-03-03T17:30:58Z

I see some issues on the UX side, that would be good to address:
The final link to Analytics does not look as a CTA, but more like a secondary action. Also, the copy does not tell what you will see. I think something better would be `View Results`.
In this final stage, the Run now button looks like the main CTA. This might be called Run again instead, with a secondary button variation.

I see some issues on the UX side, that would be good to address:
The final link to Analytics does not look as a CTA, but more like a secondary action. Also, the copy does not tell what you will see. I think something better would be `View Results`.

I think we will stick to the Figma for the first iteration

In this final stage, the Run now button looks like the main CTA. This might be called Run again instead, with a secondary button variation.

I think we will stick to the Figma for the first iteration and update if and when we have an updated Figma. I changed the code so it no longer shows the footer buttons (including run now) when the report is available, see screenshots:

benchmark ready

benchmark running

benchmark succeeeded without any failed workflows

benchmark succeeded with failed workflows

sonarqubecloud · 2026-03-03T20:27:56Z

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cezudas added 5 commits March 2, 2026 18:28

Create endpoint to list benchmarks and optional filter by provider

acabec3

Refactor for DRY and performance

6db471a

Undo change in getBenchmarkStatus

715fe33

Extract resolveStatusByBenchmarkId to encapsulate the

e6ac26f

flow-rows → orchestrator-filter → run-fetch pipeline, leaving listBenchmarks as three sequential, decoupled steps.

Group flow rows by benchmark ID before resolving statuses

78ddea7

Implement run benchmark UI

75f9878

cezudas force-pushed the cezudas/OPS-3776 branch from 134dfd4 to 75f9878 Compare March 2, 2026 17:36

Undo

c858dc0

Base automatically changed from cezudas/OPS-3780-list to main March 2, 2026 18:07

cezudas added 8 commits March 3, 2026 09:00

Merge branch 'main' into cezudas/OPS-3776

78ab528

Use QueryKeys

a069e26

Add workflow progress indicator to benchmark running state

63ccf80

Merge branch 'main' into cezudas/OPS-3776

7b65143

Remove footer from benchmark-ready-step

8f32f11

Refactor

a81ace3

Fix link to report

dc829a0

Move buttons to footer component

cafcec1

cezudas requested review from Copilot and ravikiranvm March 3, 2026 12:57

cezudas marked this pull request as ready for review March 3, 2026 12:57

Copilot started reviewing on behalf of cezudas March 3, 2026 12:57 View session

Fix lint warning

5f23adb

Copilot AI reviewed Mar 3, 2026

View reviewed changes

alexandrudanpop reviewed Mar 3, 2026

View reviewed changes

packages/react-ui/src/app/features/benchmark/use-benchmark-run.ts Show resolved Hide resolved

cezudas and others added 4 commits March 3, 2026 17:51

Apply suggestions from code review

174b779

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Handle promise rejection when clicking run

bb37b04

Address polling reset

139ec78

Add cache busting for get method for the browser context

34e9a11

cezudas added 3 commits March 3, 2026 18:57

Add console.warn for debugging silent returns

464f03f

Do not show benchmark wizard footer when report is ready

89e5678

Show copy from previous step and stack down copy and results from cur…

3410b0f

…rent step

Merge branch 'main' into cezudas/OPS-3776

7931821

cezudas requested a review from alexandrudanpop March 3, 2026 17:53

cezudas added 4 commits March 3, 2026 21:30

Fix benchmark cleanup webhook 500 on non-local environments

949bccb

Merge branch 'cezudas/OPS-3829' into cezudas/OPS-3776

8b3e460

Fix failing test

308329f

Merge branch 'cezudas/OPS-3829' into cezudas/OPS-3776

e79330f

cezudas changed the base branch from main to cezudas/OPS-3829 March 3, 2026 19:56

Rollback changes

ab0bb0f

cezudas changed the base branch from cezudas/OPS-3829 to main March 3, 2026 20:26

alexandrudanpop approved these changes Mar 4, 2026

View reviewed changes

cezudas merged commit 2b0320a into main Mar 4, 2026
20 checks passed

cezudas deleted the cezudas/OPS-3776 branch March 4, 2026 09:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement run benchmark UI#2041

Implement run benchmark UI#2041
cezudas merged 29 commits intomainfrom
cezudas/OPS-3776

cezudas commented Mar 2, 2026 •

edited

Loading

Uh oh!

linear bot commented Mar 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Mar 3, 2026

Uh oh!

Copilot AI Mar 3, 2026

Uh oh!

cezudas Mar 3, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexandrudanpop commented Mar 3, 2026 •

edited

Loading

Uh oh!

cezudas commented Mar 3, 2026 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Mar 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-          {`${t('— Running workflows')} ${progress.completed}/${
-            progress.total
-          }...`}
+          {t('— Running workflows {{completed}}/{{total}}...', {
+            completed: progress.completed,
+            total: progress.total,
+          })}

Conversation

cezudas commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear bot commented Mar 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

cezudas Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexandrudanpop commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cezudas commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 3, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cezudas commented Mar 2, 2026 •

edited

Loading

alexandrudanpop commented Mar 3, 2026 •

edited

Loading

cezudas commented Mar 3, 2026 •

edited

Loading