Fix vehicle teleport bug and revert issue 735#893
Open
dimmyi wants to merge 3 commits intoopenmultiplayer:masterfrom
Open
Fix vehicle teleport bug and revert issue 735#893dimmyi wants to merge 3 commits intoopenmultiplayer:masterfrom
dimmyi wants to merge 3 commits intoopenmultiplayer:masterfrom
Conversation
Stream the vehicle driver immediately to avoid the vehicle teleport bug after spectating a vehicle and a player is driving the vehicle.
Forcing someone to exit spectator mode when destroying a vehicle breaks many systems. Most admin spectator systems when a player enters a vehicle, the admin starts spectating the player's vehicle, and if some other system, for example storing the vehicle in the garage using DestroyVehicle, would force the admin to stop the mode spectator before even knowing that the player left the vehicle.
|
|
Contributor
|
Does the first change now make the behaviour like in samp server? |
Member
|
Attempting to stream the vehicle right away is indeed the right thing to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Forcing someone to exit spectator mode when destroying a vehicle breaks many systems.
Most admin spectator systems when a player enters a vehicle, the admin starts spectating the player's vehicle, and if some other system, for example storing the vehicle in the garage using DestroyVehicle, would force the admin to stop the mode spectator before even knowing that the player left the vehicle.
2. Stream the vehicle driver immediately to avoid the vehicle teleport bug after spectating a vehicle and have a driver. This causes the vehicle to stay in position for a moment and when the driver is StreamIn the vehicle teleports to its position.