Repository navigation
Conversation
pjeweb
force-pushed
the
symbol-optional-dependencies
branch
from
November 2, 2026 00:23
7496fdb to
605fd82
Compare
pjeweb
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1566 together with openlayers/openlayers#17723.
Implements the
icon-optionalandtext-optionallayout properties. Both default tofalsein the style specification, so an icon and its text are only shown together.Until now, ol-mapbox-style ignored them. When an icon collided while its text was allowed to overlap, as with
text-allow-overlap: trueandicon-allow-overlap: false, the text stayed visible on its own. For example, in a road shield layer styled like this, a route number could appear without its shield, on top of a neighboring shield.The properties are passed to
setOptional()of the OpenLayers image and text styles. With OpenLayers versions that lacksetOptional(), nothing changes and the new test is skipped.