Skip to content

8355779: When no "signature_algorithms_cert" extension is present we do not apply certificate scope constraints to algorithms in "signature_algorithms" extension#834

Open
jerboaa wants to merge 1 commit into
openjdk:pr/830from
jerboaa:jdk-8355779-sigalg-ext-cert-fix
Open

Conversation

@jerboaa

@jerboaa jerboaa commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Clean backport of a follow-up to #830. The patch applies clean after path modification.

Testing:

Thoughts?


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8355779 needs maintainer approval

Integration blocker

 ⚠️ Dependency #830 must be integrated first

Issue

  • JDK-8355779: When no "signature_algorithms_cert" extension is present we do not apply certificate scope constraints to algorithms in "signature_algorithms" extension (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/834/head:pull/834
$ git checkout pull/834

Update a local copy of the PR:
$ git checkout pull/834
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/834/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 834

View PR using the GUI difftool:
$ git pr show -t 834

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/834.diff

Using Webrev

Link to Webrev Comment

8355779: When no "signature_algorithms_cert" extension is present we do not apply certificate scope constraints to algorithms in "signature_algorithms" extension
@bridgekeeper

bridgekeeper Bot commented Jun 16, 2026

Copy link
Copy Markdown

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into pr/830 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 16, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 151f708c26c665de1a50f4757580326fbf870297 8355779: When no "signature_algorithms_cert" extension is present we do not apply certificate scope constraints to algorithms in "signature_algorithms" extension Jun 16, 2026
@openjdk

openjdk Bot commented Jun 16, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added the backport Port of a pull request already in a different code base label Jun 16, 2026
@jerboaa jerboaa marked this pull request as ready for review June 16, 2026 12:37
@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 16, 2026
@mlbridge

mlbridge Bot commented Jun 16, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant