8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message

[jerboaa]

Please review this fairly low-risk backport to the ServerHello TLS 1.3 message. I'm backporting this change since it also introduces changes to SSLEngineTemplate.java which is needed to make the added test in the JDK-8263188 backport to compile. This patch is also in Oracle JDK 8u. JDK-8263188 is the backport I'm proposing next.

The only manual fix-up was in the copyright. Clean otherwise modulo path changes.

Testing:

jdk/test/javax/net/ssl, jdk/test/sun/net/www/protocol/https/ and jdk/test/sun/security/ssl/ tests. All pass (including the new test, which also seems to pass on unpatched, though). Results (same 3 known issues. See #808):

Test results: passed: 266; failed: 2; error: 1

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8326643 needs maintainer approval

Integration blocker

 ⚠️ Dependency #809 must be integrated first

Issue

• JDK-8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/810/head:pull/810
$ git checkout pull/810

Update a local copy of the PR:
$ git checkout pull/810
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/810/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 810

View PR using the GUI difftool:
$ git pr show -t 810

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/810.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into pr/809 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full (7dcac358)
• 01: Full - Incremental (37e03efc)
• 00: Full (37e03efc)

[openjdk]

@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

@jerboaa this pull request can not be integrated into pr/809 due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout jdk-8326643-server-hello-fix-8u
git fetch https://git.openjdk.org/jdk8u-dev.git pr/809
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/809"
git push