Skip to content

8369032: Add test to ensure serialized ICC_Profile stores only necessary optional data#777

Open
mrserb wants to merge 3 commits into
openjdk:masterfrom
mrserb:JDK-8369032
Open

8369032: Add test to ensure serialized ICC_Profile stores only necessary optional data#777
mrserb wants to merge 3 commits into
openjdk:masterfrom
mrserb:JDK-8369032

Conversation

@mrserb

@mrserb mrserb commented Mar 21, 2026

Copy link
Copy Markdown
Member

Hi all,

This pull request contains a backport of commit ed153ee2 from the openjdk/jdk repository.

The backport is mostly clean: I have to update the test to use explicit types in SerializedFormSize instead of var.

The commit being backported was authored by Sergey Bylokhov on 21 Oct 2025 and was reviewed by Harshitha Onkar.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8369032 needs maintainer approval

Issue

  • JDK-8369032: Add test to ensure serialized ICC_Profile stores only necessary optional data (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/777/head:pull/777
$ git checkout pull/777

Update a local copy of the PR:
$ git checkout pull/777
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/777/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 777

View PR using the GUI difftool:
$ git pr show -t 777

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/777.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Mar 21, 2026

Copy link
Copy Markdown

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Mar 21, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport ed153ee2c4614c814da92c23c4741eed68ce1a0c 8369032: Add test to ensure serialized ICC_Profile stores only necessary optional data Mar 21, 2026
@openjdk

openjdk Bot commented Mar 21, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added the backport Port of a pull request already in a different code base label Mar 21, 2026
@mrserb mrserb marked this pull request as ready for review March 21, 2026 23:08
@openjdk openjdk Bot added the rfr Pull request is ready for review label Mar 21, 2026
@mlbridge

mlbridge Bot commented Mar 21, 2026

Copy link
Copy Markdown

Webrevs

@bridgekeeper

bridgekeeper Bot commented Apr 19, 2026

Copy link
Copy Markdown

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb

mrserb commented Apr 20, 2026

Copy link
Copy Markdown
Member Author

/keepalive

@openjdk

openjdk Bot commented Apr 20, 2026

Copy link
Copy Markdown

@mrserb The pull request is being re-evaluated and the inactivity timeout has been reset.

@openjdk openjdk Bot removed the rfr Pull request is ready for review label Apr 20, 2026
@mrserb

mrserb commented Apr 28, 2026

Copy link
Copy Markdown
Member Author

/template append

@openjdk

openjdk Bot commented Apr 28, 2026

Copy link
Copy Markdown

@mrserb The pull request template has been appended to the pull request body

@openjdk openjdk Bot added the rfr Pull request is ready for review label Apr 28, 2026
@bridgekeeper

bridgekeeper Bot commented May 27, 2026

Copy link
Copy Markdown

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@gnu-andrew gnu-andrew left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, only just spotted this one. The backport looks good with the appropriate var removal. I assume the test does pass on 8u? :)

@openjdk

openjdk Bot commented May 29, 2026

Copy link
Copy Markdown

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mrserb

mrserb commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

Sorry, only just spotted this one. The backport looks good with the appropriate var removal. I assume the test does pass on 8u? :)

Yes it works fine.

@mrserb

mrserb commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

/approval request
Added a test to validate the stream of serialized ICC profiles. Verified to work correctly on JDK 8.

@openjdk

openjdk Bot commented Jun 5, 2026

Copy link
Copy Markdown

@mrserb
8369032: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants