feat!: Upgrade to TypeScript 6 & 7 - #20
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@arbrandes Could you please take a quick look at this? I'm also not sure why github says a |
Making local changes to cross-cutting libraries like this one (including frontend-base itself) and testing them is indeed foreseen and supported when using https://github.com/openedx/frontend-template-site for development. (Getting it to work required us to resort to NPM workspaces and then Turbo to do the builds in the proper order, but it does work.) But since we're on the subject, I've been asking these whenever I see major upgrades in frontend-platform land:
|
Definitely, but I took a quick stab at it and it's unfortunately non-trivial. To upgrade
Sure, but my fear is that if we can't do these upgrades now, which should be fairly routine, when we have only 2-3 MFEs, isn't it going to be even harder to do them when we have 12+ MFEs all using frontend-base? |
Probably. But this is the price to pay for consistency across the org's codebase. However, the hope is that once all apps are consistent, then upgrades - while not necessarily straightforward, like this one - become easy enough to apply across the board once the first example exists. LLMs have to be good for something, right? :) |
I guess we're not using this with
frontend-base, but I'd still like to get the Authoring MFE upgraded to TS6+.As I understand, I need to:
frontend-buildto pull in newedx/typescript-configandts-jestfrontend-platformto pull in newfrontend-buildand bumpreact-intlto fix formatjs dependency on TS 5Doing dependency upgrades like this across so many repos is a big pain, especially with semantically-released making the package.jsons uninstallable and
npm linknot installingbinscripts as normal. So it's very difficult to test anything until each package is published to NPM. I do hopefrontend-basesolves this.