build: Don't update common_constraints.txt on re-compilation.#37797
Merged
build: Don't update common_constraints.txt on re-compilation.#37797
Conversation
Re-compilation and upgrade-package should be able to run without updating the common_constraints.txt file. We do this all the time when backporting fixes to older releases. We shouldn't pull in the latest common_constraints.txt in those cases as they may not be compatible with older releases.
ormsbee
approved these changes
Dec 19, 2025
Contributor
|
@feanil: Does this PR also have to get backported to Ulmo so that this LC version bump backport doesn't get flagged on the "Consistent Python dependencies" step? |
Contributor
Author
|
Ah, yea, it looks like it does, I'll make the backport PR now. |
Contributor
Author
|
Backport PR: #37799 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-compilation and upgrade-package should be able to run without
updating the common_constraints.txt file. We do this all the time when
backporting fixes to older releases. We shouldn't pull in the latest
common_constraints.txt in those cases as they may not be compatible with
older releases.