Frontend base Migration - #210
Conversation
|
Thanks for the pull request, @jesusbalderramawgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| isSearchable?: boolean, | ||
| onSearchChange?: (value: string) => void, | ||
| iconSrc?: React.ComponentType | undefined, | ||
| disabled?: boolean, |
There was a problem hiding this comment.
What changed these ; to , ? Semicolons are the standard for TypeScript interfaces and most code formatters and linters enforce that. Restoring these to ; is not only more correct but will make this diff smaller.
There was a problem hiding this comment.
Hmm, @arbrandes do you if it was a deliberate decision to change the eslint config in frontend-base so that member-delimiter-style requires commas instead of the default semicolons?
It's not a big deal, but it seems like it's making all our "convert to frontend-base" diffs noisy, and goes against the usual standard in the TypeScript world.
There was a problem hiding this comment.
Yeah, I've run into this in the past, and found it annoying. I don't remember ever discussing this with David, though, so don't actually know why.
But at the same time it feels weird to go back to all the frontend-base repos to change it back. Ug.
There was a problem hiding this comment.
IMHO that's why we should actually use the "warnings vs. errors" feature that linters (eslint & oxlint) have. We could mark the comma as a warning, the semicolon as correct, and then never worry about it again. This diff would be smaller, and the existing frontend-base codebases would be fine, and could be slowly brought into alignment.
But we have a configuration that basically treats warnings as errors, so we don't really take advantage of that.
| name: 'Test User', | ||
| administrator: false, | ||
| roles: [], | ||
| avatar: '', |
There was a problem hiding this comment.
I think this boilerplate should be factored out into a common testUtils file. It's very verbose to have it repeated so many times in each test suite. The way we do it via testUtils in the authoring MFE has been nice.
beforeEach(() => {
initializeMockApp({
authenticatedUser: {
userId: 1,
username: 'testuser',
email: 'testuser@example.com',
name: 'Test User',
administrator: false,
roles: [],
avatar: '',
},
});There was a problem hiding this comment.
agree! I will refactor this, thanks

Description
PR to migrate this repository to frontend base. It closes this issue.
Turning the MFE into a library that runs inside the
frontend-base shell. Follows the official "Migrating an MFE to frontend-base" guide.
How I have tested this change?
Screenshots
Closes #211