Remove mandatory parameters when requesting an automated deletion#45
Open
ivan-risueno wants to merge 2 commits intomasterfrom
Open
Remove mandatory parameters when requesting an automated deletion#45ivan-risueno wants to merge 2 commits intomasterfrom
ivan-risueno wants to merge 2 commits intomasterfrom
Conversation
jordivx
requested changes
May 6, 2026
Contributor
jordivx
left a comment
jordivx
left a comment
There was a problem hiding this comment.
Currently this extra check is already done in the PR: https://github.com/opendevstack/ods-component-provisioner/pull/24/changes#diff-ce9329729669bcdbb2d29ea1564121b0b81b4f3ec6a5048ed63dad68636d3b2cR220
Once that is merged, verify if some parts of this is still required, but most of it seems already covered.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.