Implement reserved parameter validation for project component creation#24
Implement reserved parameter validation for project component creation#24
Conversation
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
| public class ProjectComponentsCreateProperties { | ||
|
|
||
| private List<String> reservedParams = new ArrayList<>( | ||
| List.of("workflow", "ods_namespace", "component_type", "quickstarter_repo") |
There was a problem hiding this comment.
The list should be provided via configuration, not hardcoded
| return; | ||
| } | ||
|
|
||
| if (createProperties.getReservedParams() == null || createProperties.getReservedParams().isEmpty()) { |
There was a problem hiding this comment.
maybe we haven't even configure the createProperties (it should check if it is null or it will throw a NPE
There was a problem hiding this comment.
I think this comment is not applicable: createProperties is constructor-injected and final, so it should not be null at runtime. The actual nullable part iscreateProperties.getReservedParams(), and that is already checked here.
|
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
2 participants
No description provided.