Feature/marketplace deletion by valituguran · Pull Request #23 · opendevstack/ods-api-service

valituguran · 2026-05-06T14:39:55Z

Update marketplace deletion service and controller with tests.

…sage # Conflicts: # api-project-component-v0/src/main/java/org/opendevstack/apiservice/project/controller/ComponentsResponseFactory.java # api-project-component-v0/src/main/java/org/opendevstack/apiservice/project/controller/ProjectComponentsController.java # api-project-component-v0/src/main/java/org/opendevstack/apiservice/project/facade/ComponentsFacade.java # api-project-component-v0/src/main/java/org/opendevstack/apiservice/project/mapper/MarketplaceMapper.java # api-project-component-v0/src/test/java/org/opendevstack/apiservice/project/controller/ProjectComponentsControllerTest.java # api-project-component-v0/src/test/java/org/opendevstack/apiservice/project/facade/ComponentsFacadeTest.java # api-project-component-v0/src/test/java/org/opendevstack/apiservice/project/util/TestObjectsBuilder.java # external-service-marketplace/src/main/java/org/opendevstack/apiservice/externalservice/marketplace/model/ProjectComponent.java # external-service-marketplace/src/main/java/org/opendevstack/apiservice/externalservice/marketplace/service/impl/MarketplaceServiceMockImpl.java

…ate components and added mandatory parameters to the marketplace 2.0 provision component call

…ent by project key and component ID

#20) … Marketplace API client with bearer token support --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…tFoundException

…ad requests

…ds from MarketplaceInstanceConfig and MarketplaceServiceImpl

…nts-api-usage' into feature/real-marketplace-components-api-usage

# Conflicts: # Makefile # api-project-component-v0/src/main/java/org/opendevstack/apiservice/project/controller/ProjectComponentsController.java # api-project-component-v0/src/main/java/org/opendevstack/apiservice/project/controller/advice/ProjectComponentsExceptionHandler.java # api-project-component-v0/src/main/java/org/opendevstack/apiservice/project/facade/ComponentsFacade.java # api-project-component-v0/src/main/java/org/opendevstack/apiservice/project/mapper/MarketplaceMapper.java # api-project-component-v0/src/test/java/org/opendevstack/apiservice/project/facade/ComponentsFacadeTest.java # application.yaml # core-security/src/main/java/org/opendevstack/apiservice/core/security/jwt/JwtUtils.java # external-service-marketplace/openapi/openapi-component_catalog-v1.0.0.yaml # external-service-marketplace/openapi/openapi-component_provisioner-v1.0.0.yaml # external-service-marketplace/pom.xml # external-service-marketplace/src/main/java/org/opendevstack/apiservice/externalservice/marketplace/client/MarketplaceApiClient.java # external-service-marketplace/src/main/java/org/opendevstack/apiservice/externalservice/marketplace/client/MarketplaceApiClientFactory.java # external-service-marketplace/src/main/java/org/opendevstack/apiservice/externalservice/marketplace/config/MarketplaceInstanceConfig.java # external-service-marketplace/src/main/java/org/opendevstack/apiservice/externalservice/marketplace/service/CatalogItemOperations.java # external-service-marketplace/src/main/java/org/opendevstack/apiservice/externalservice/marketplace/service/MarketplaceService.java # external-service-marketplace/src/main/java/org/opendevstack/apiservice/externalservice/marketplace/service/impl/MarketplaceServiceImpl.java # external-service-marketplace/src/test/java/org/opendevstack/apiservice/externalservice/marketplace/service/MarketplaceServiceImplTest.java

github-actions · 2026-05-06T14:47:10Z

📊 Static Analysis Summary

🔍 Code Quality Checks

✅ JaCoCo coverage report generated

📦 Download detailed reports from the workflow artifacts.

github-actions · 2026-05-06T14:51:26Z

📊 Static Analysis Summary

🔍 Code Quality Checks

✅ JaCoCo coverage report generated

📦 Download detailed reports from the workflow artifacts.

github-actions · 2026-05-07T06:44:57Z

📊 Static Analysis Summary

🔍 Code Quality Checks

✅ JaCoCo coverage report generated

📦 Download detailed reports from the workflow artifacts.

github-actions · 2026-05-07T06:51:12Z

📊 Static Analysis Summary

🔍 Code Quality Checks

✅ JaCoCo coverage report generated

📦 Download detailed reports from the workflow artifacts.

github-actions · 2026-05-07T07:06:24Z

📊 Static Analysis Summary

🔍 Code Quality Checks

✅ JaCoCo coverage report generated

📦 Download detailed reports from the workflow artifacts.

Copilot

Pull request overview

This PR updates the Marketplace “delete component” flow to use the provisioner’s new deleteProvisioningStatus endpoint (204 No Content) and adapts the project-component API to expose a corresponding internal delete endpoint, including supporting tests.

Changes:

Switched Marketplace deletion from the old “create incident” flow to deleteProvisioningStatus, and updated the service API from boolean to void.
Added basic-auth support to the Marketplace API client via new instance config fields (username/password).
Introduced an internal project-component delete controller + OpenAPI spec + generation config, and updated facade behavior/tests to throw ComponentDeletionException on deletion failures.

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
external-service-marketplace/src/test/java/.../MarketplaceServiceImplTest.java	Updates health/deletion tests (currently has a signature mismatch in delete tests).
external-service-marketplace/src/main/java/.../MarketplaceService.java	Changes delete methods to `void` to reflect 204/no-body behavior.
external-service-marketplace/src/main/java/.../impl/MarketplaceServiceImpl.java	Implements deletion via `deleteProvisioningStatus` using a request body.
external-service-marketplace/src/main/java/.../config/MarketplaceInstanceConfig.java	Adds basic-auth credentials fields to instance config.
external-service-marketplace/src/main/java/.../client/MarketplaceApiClientFactory.java	Formatting-only change.
external-service-marketplace/src/main/java/.../client/MarketplaceApiClient.java	Applies basic-auth credentials onto the generated ApiClient.
external-service-marketplace/pom.xml	Updates OpenAPI generation filter to include `deleteProvisioningStatus`.
external-service-marketplace/openapi/openapi-component_provisioner-v1.0.0.yaml	Updates delete response code to 204 for `deleteProvisioningStatus`.
api-project-component-v0/src/test/java/.../ComponentsFacadeTest.java	Adds facade tests for delete behavior.
api-project-component-v0/src/test/java/.../ProjectComponentsInternalControllerTest.java	Adds tests for the new internal delete controller.
api-project-component-v0/src/test/java/.../ProjectComponentsControllerTest.java	Trailing whitespace change only.
api-project-component-v0/src/main/java/.../facade/ComponentsFacade.java	Changes delete facade to `void` and throws `ComponentDeletionException` on failures.
api-project-component-v0/src/main/java/.../exception/ComponentDeletionException.java	Adds a runtime exception type for deletion failures.
api-project-component-v0/src/main/java/.../controller/ProjectComponentsInternalController.java	Adds internal v1 delete endpoint returning 204.
api-project-component-v0/src/main/java/.../controller/advice/ProjectComponentsExceptionHandler.java	Adds deletion exception handler (currently has a wrong parameter type).
api-project-component-v0/pom.xml	Adds OpenAPI generation execution for the internal API.
api-project-component-v0/openapi/api-project-component-v0-internal.yaml	Defines the internal delete endpoint (204) and security schemes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+        // Act & Assert
+        assertThrows(MarketplaceException.class, () ->
+                marketplaceService.deleteProjectComponent(instanceName, componentId));



sonarqubecloud · 2026-05-07T09:34:23Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-05-07T09:40:55Z

📊 Static Analysis Summary

🔍 Code Quality Checks

✅ JaCoCo coverage report generated

📦 Download detailed reports from the workflow artifacts.

zxBCN Valeriu_Tuguran,Constantin (IT EDP) EXTERNAL and others added 24 commits April 14, 2026 15:50

Add marketplace api client.

636cc1c

Add marketplace api client.

27682ee

Remove unused var.

2c9e956

Fix sonarqube complaints.

6ee3a28

Add delete component functionality - not finished.

cf25bfb

Add delete component functionality - not finished.

0e72bc9

Implement component existence check and exception handling for duplic…

4138b18

…ate components and added mandatory parameters to the marketplace 2.0 provision component call

Add API endpoint to retrieve extended information of a project compon…

911780e

…ent by project key and component ID

Update getComponent to call the new endpoint.

3d708a6

Implement On-Behalf-Of (OBO) token exchange functionality and enhance… (

05fa84f

#20) … Marketplace API client with bearer token support --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix github comments.

db955b7

Refactor exception handling in getProjectComponent to use ComponentNo…

05a1abf

…tFoundException

Add ComponentBadRequestException and enhance exception handling for b…

3a7c372

…ad requests

Remove unused workflow, odsNamespace, and quickstarterRepository fiel…

2febcc7

…ds from MarketplaceInstanceConfig and MarketplaceServiceImpl

Fix test.

5dff575

Merge remote-tracking branch 'origin/feature/real-marketplace-compone…

d899671

…nts-api-usage' into feature/real-marketplace-components-api-usage

Add delete service and controller.

14c7d6b

Add tests.

d44279d

Update delete with latest API changes.

b9bec95

Update delete with latest API changes.

31139b6

Fixes after the merge with develop.

ad2e7fa

Fix test.

c95e565

zxBCN Valeriu_Tuguran,Constantin (IT EDP) EXTERNAL added 2 commits May 7, 2026 08:38

Update log message.

84e6fbf

Fix code analysis findings.

b01b11c

Fix code analysis findings.

0d678e6

jorge-romero requested a review from Copilot May 7, 2026 07:22

Copilot started reviewing on behalf of jorge-romero May 7, 2026 07:23 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

angelmp01 reviewed May 7, 2026

View reviewed changes

Comment thread api-project-component-v0/openapi/api-project-component-v0-internal.yaml

Fix PR review findings.

5dc0734

jorge-romero approved these changes May 7, 2026

View reviewed changes

valituguran merged commit f7c9aae into develop May 7, 2026
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/marketplace deletion#23

Feature/marketplace deletion#23
valituguran merged 28 commits intodevelopfrom
feature/marketplace-deletion

valituguran commented May 6, 2026

Uh oh!

github-actions Bot commented May 6, 2026

Uh oh!

github-actions Bot commented May 6, 2026

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented May 7, 2026

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

valituguran commented May 6, 2026

Uh oh!

github-actions Bot commented May 6, 2026

📊 Static Analysis Summary

🔍 Code Quality Checks

Uh oh!

github-actions Bot commented May 6, 2026

📊 Static Analysis Summary

🔍 Code Quality Checks

Uh oh!

github-actions Bot commented May 7, 2026

📊 Static Analysis Summary

🔍 Code Quality Checks

Uh oh!

github-actions Bot commented May 7, 2026

📊 Static Analysis Summary

🔍 Code Quality Checks

Uh oh!

github-actions Bot commented May 7, 2026

📊 Static Analysis Summary

🔍 Code Quality Checks

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented May 7, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented May 7, 2026

📊 Static Analysis Summary

🔍 Code Quality Checks

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants