Repository navigation
feat(linux): --launch opens the pages xdg-open passes; desktop entry handles web content - #63
Merged
Merged
Conversation
…handles web content Clicking an .html file or a link could not open in ego lite: the desktop entry ran --spaces with no %U, so the page never reached the browser, and the desktop had no MimeType to offer it for. --launch [url|file ...] opens each page in a plain tab of the shared window (not ego.createTab, which files it into the agents' selected task space and does nothing while a person controls that space) and raises it; with no pages it still shows the Spaces overview. --open now shares that code path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… browser Review of #63: anything xdg-open hands over opens in the browser the agents drive with their logins, so javascript:, chrome:// and view-source: now read as paths (and so do Windows drive paths and single-dash arguments). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Double-clicking an
.htmlfile, or choosing ego lite as the HTML handler, opened nothing. The desktop entry ran--spaceswithout%U, so the file never reached the browser, and the entry declared noMimeType.What
--launch [url|file ...]opens each page in a plain tab of the shared window and raises it. With no arguments it shows the Spaces overview, as before.file://URL (launchTargetsinsrc/desktop.mjs).Target.createTarget, notego.createTab.ego.createTabfiles the tab into the agents' selected task space and silently does nothing while a person has taken that space over, which is how the first attempt failed.--opennow shares the sameopenPages()code.Exec=… --launch %U, plusMimeType=text/html;application/xhtml+xml;x-scheme-handler/http;x-scheme-handler/https;.Checks
test/desktop-entry.test.mjs: 3/3 pass, including the new tests for Exec/MimeType andlaunchTargets.installer.test.mjsanddoctor-cli.test.mjsfail the same way onorigin/mainon this machine, so this PR adds no new failures.ego-browser.mjs --launch <report.html>opened the report tab. Confirmed with the DevTools target list while a person had taken control of the task space.🤖 Generated with Claude Code