Skip to content

feat: add swagger for REST API#2

Open
VladimirBalun wants to merge 1 commit intodevelopfrom
feature/swagger_for_rest_api
Open

feat: add swagger for REST API#2
VladimirBalun wants to merge 1 commit intodevelopfrom
feature/swagger_for_rest_api

Conversation

@VladimirBalun
Copy link
Copy Markdown
Contributor

No description provided.

@VladimirBalun VladimirBalun added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 18, 2022
Comment thread api/rest_openapi.yaml
type : string
requestBody:
required: true
content:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PUT method.
Missing the fields available to update.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we intend to allow updating only status, no?

Comment thread api/rest_openapi.yaml

info:
title: Crasher REST API
description: Current API describes UI interaction with Crasher
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we consider "Crasher" as the whole system that consists of UI, language libraries and server? If so let's say with Crasher Server.

Comment thread api/rest_openapi.yaml
description: url path for next pagination page
required:
- totalSize
- self
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does server tells a client that it was the last page? By totalSize = 0?

Comment thread api/rest_openapi.yaml
- 0
- 1
- 2
- 3
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems to me that it can be bad approach to make enums in rest api, i think it's better to use string representations of status.

Comment thread api/rest_openapi.yaml
500:
description: Server error
delete:
summary: Delete all core dumps
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add some optional parameters, by application, by status and etc.?

Comment thread api/rest_openapi.yaml
type : string
requestBody:
required: true
content:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we intend to allow updating only status, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants