feat(riscv): add Zicond integer conditional operations#899
Open
regehr wants to merge 3 commits into
Open
Conversation
Adds the two RISC-V Zicond R-type instructions to the riscv dialect: czero.eqz and czero.nez (spelled riscv.czeroeqz / riscv.czeronez, following the dot-collapsing convention used by orcb / rev8). Covers opcodes, register-level semantics and lemmas, interpreter, verifier, an identity round-trip, and interpreter tests that pin down the eqz/nez semantics via a non-commutative shift. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
VeIR Benchmarks
Details
| Benchmark suite | Current: a765d7f | Previous: cc0b571 | Ratio |
|---|---|---|---|
add-fold-worklist/create |
2414000 ns (± 46519) |
2245000 ns (± 59823) |
1.08 |
add-fold-worklist/rewrite |
4000000 ns (± 57335) |
3943000 ns (± 62416) |
1.01 |
add-fold-worklist-local/create |
2412000 ns (± 101083) |
2268000 ns (± 50000) |
1.06 |
add-fold-worklist-local/rewrite |
3505000 ns (± 166840) |
3319000 ns (± 31736) |
1.06 |
add-zero-worklist/create |
2343000 ns (± 113602) |
2235000 ns (± 108232) |
1.05 |
add-zero-worklist/rewrite |
2889500 ns (± 140164) |
2508000 ns (± 31572) |
1.15 |
add-zero-reuse-worklist/create |
2007500 ns (± 121571) |
1834000 ns (± 90486) |
1.09 |
add-zero-reuse-worklist/rewrite |
2315500 ns (± 116500) |
2108000 ns (± 32722) |
1.10 |
mul-two-worklist/create |
2376000 ns (± 102619) |
2248000 ns (± 109222) |
1.06 |
mul-two-worklist/rewrite |
5792000 ns (± 82830) |
5544500 ns (± 143297) |
1.04 |
add-fold-forwards/create |
2286500 ns (± 128711) |
2205000 ns (± 111151) |
1.04 |
add-fold-forwards/rewrite |
3059000 ns (± 59492) |
2998000 ns (± 62583) |
1.02 |
add-zero-forwards/create |
2251500 ns (± 109969) |
2291000 ns (± 81627) |
0.98 |
add-zero-forwards/rewrite |
1992500 ns (± 44188) |
1903000 ns (± 92249) |
1.05 |
add-zero-reuse-forwards/create |
1937000 ns (± 95744) |
1866500 ns (± 87239) |
1.04 |
add-zero-reuse-forwards/rewrite |
1542000 ns (± 37673) |
1562000 ns (± 24410) |
0.99 |
mul-two-forwards/create |
2203000 ns (± 43397) |
2189000 ns (± 55971) |
1.01 |
mul-two-forwards/rewrite |
3665000 ns (± 42705) |
3612000 ns (± 88471) |
1.01 |
add-zero-reuse-first/create |
1917500 ns (± 107179) |
1862000 ns (± 71721) |
1.03 |
add-zero-reuse-first/rewrite |
8000 ns (± 2218) |
8000 ns (± 2593) |
1 |
add-zero-lots-of-reuse-first/create |
1999000 ns (± 104060) |
1815000 ns (± 64825) |
1.10 |
add-zero-lots-of-reuse-first/rewrite |
830000 ns (± 27070) |
785000 ns (± 22749) |
1.06 |
This comment was automatically generated by workflow using github-action-benchmark.
tobiasgrosser
left a comment
tobiasgrosser
left a comment
Collaborator
There was a problem hiding this comment.
Nice. Let's see what @luisacicolini is saying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.