test(EDyadicFloat): conformance vs FastFloat at matching (e,s,mode)#793
Open
bollu wants to merge 1 commit into
Open
test(EDyadicFloat): conformance vs FastFloat at matching (e,s,mode)#793bollu wants to merge 1 commit into
bollu wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
VeIR Benchmarks
Details
| Benchmark suite | Current: 60ded2f | Previous: eb0390c | Ratio |
|---|---|---|---|
add-fold-worklist/create |
1860000 ns (± 82428) |
2198000 ns (± 109413) |
0.85 |
add-fold-worklist/rewrite |
3336000 ns (± 38833) |
3733000 ns (± 84672) |
0.89 |
add-fold-worklist-local/create |
1835000 ns (± 67266) |
2191000 ns (± 99246) |
0.84 |
add-fold-worklist-local/rewrite |
2856000 ns (± 59848) |
3011000 ns (± 27372) |
0.95 |
add-zero-worklist/create |
1845000 ns (± 75967) |
2140500 ns (± 109777) |
0.86 |
add-zero-worklist/rewrite |
2104000 ns (± 33538) |
2383000 ns (± 53970) |
0.88 |
add-zero-reuse-worklist/create |
1619000 ns (± 75281) |
1798000 ns (± 63295) |
0.90 |
add-zero-reuse-worklist/rewrite |
1779000 ns (± 67389) |
1965000 ns (± 30368) |
0.91 |
mul-two-worklist/create |
1854000 ns (± 67592) |
2191000 ns (± 103104) |
0.85 |
mul-two-worklist/rewrite |
4750000 ns (± 152730) |
5176000 ns (± 80037) |
0.92 |
add-fold-forwards/create |
1898000 ns (± 247338) |
2174500 ns (± 97824) |
0.87 |
add-fold-forwards/rewrite |
2722000 ns (± 311824) |
2967500 ns (± 35897) |
0.92 |
add-zero-forwards/create |
1899000 ns (± 94207) |
2115000 ns (± 33441) |
0.90 |
add-zero-forwards/rewrite |
1767000 ns (± 52823) |
1903000 ns (± 16300) |
0.93 |
add-zero-reuse-forwards/create |
1531000 ns (± 74469) |
1832000 ns (± 91568) |
0.84 |
add-zero-reuse-forwards/rewrite |
1462000 ns (± 107058) |
1555000 ns (± 50375) |
0.94 |
mul-two-forwards/create |
1861000 ns (± 71376) |
2126000 ns (± 70864) |
0.88 |
mul-two-forwards/rewrite |
3252000 ns (± 125105) |
3520000 ns (± 48872) |
0.92 |
add-zero-reuse-first/create |
1534000 ns (± 46597) |
1827500 ns (± 94828) |
0.84 |
add-zero-reuse-first/rewrite |
10000 ns (± 1995) |
8000 ns (± 1592) |
1.25 |
add-zero-lots-of-reuse-first/create |
1508000 ns (± 48247) |
1773000 ns (± 69739) |
0.85 |
add-zero-lots-of-reuse-first/rewrite |
776000 ns (± 29670) |
759000 ns (± 9407) |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
3e94d15 to
60ded2f
Compare
4090469 to
5da6715
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
UnitTest/FP/EDyadicFloat/ConformanceFastFloat.lean. BothEDyadicFloatandFastFloatare correctly rounded, so for matching(e, s, mode)they agree:(11, 52):FastFloat's internalFloatis a double, so both equal native double arithmetic — agreement on all inputs including division (no internal double-rounding possible).(8, 23):FastFloatrounds a double result down to single (can double-round on division), so we compare on the same golden inputs theFastFloatsuite already pins against nativeFloat32, narrowing both back toFloat32.Stack
Part of
full-precision-floats-edyadic(patch 6/6, final). Base: #792.🤖 Generated with Claude Code