Skip to content

fix: the replacement character should be U+FFFD, not U+FFFE #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moriyoshi merged 1 commit into from
Mar 11, 2026
Merged

fix: the replacement character should be U+FFFD, not U+FFFE #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/api.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ The MJ shrink conversion map (*MJ縮退マップ*) was also developed alongside
Transliteration based on NTA shrink mappings
--------------------------------------------

.. py:function:: jnta_shrink_translit(in_, replacement="\ufffe", passthrough=False)
.. py:function:: jnta_shrink_translit(in_, replacement="\ufffd", passthrough=False)

Transliterate a Unicode string according to the NTA shrink mappings.

Expand Down
2 changes: 1 addition & 1 deletion src/jntajis/_jntajis.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ class TransliterationError(Exception): ...
def jnta_encode(encoding: str, in_: str, conv_mode: int) -> bytes: ...
def jnta_decode(encoding: str, in_: bytes) -> str: ...
def jnta_shrink_translit(
in_: str, replacement: str = "\ufffe", passthrough: bool = False
in_: str, replacement: str = "\ufffd", passthrough: bool = False
) -> str: ...
def mj_shrink_candidates(in_: str, combo: int, limit: int = 100) -> typing.List[str]: ...
2 changes: 1 addition & 1 deletion src/jntajis/_jntajis.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,7 @@ cdef JNTAJISShrinkingTransliteratorContext_init(
t.passthrough = passthrough


def jnta_shrink_translit(unicode in_, unicode replacement=u"\ufffe", bint passthrough=False):
def jnta_shrink_translit(unicode in_, unicode replacement=u"\ufffd", bint passthrough=False):
"""
Transliterate a Unicode string according to the NTA shrink mappings.
"""
Expand Down