feat(epub-reader): improve chapter resolution and progress slider UX - #3201
Merged
Conversation
- Remove unnecessary label props from all components - Components now use $gettext() directly in templates instead of passing labels from parents - ReaderProgressBar calculates its own progress label from percent value - Remove 55 lines of redundant label prop handling and intermediate variables - Update tests to reflect simplified component APIs
AlexAndBear
force-pushed
the
feat/epub-slider-preview-percent
branch
from
August 22, 2026 21:13
f537d76 to
dc4d6dc
Compare
AlexAndBear
force-pushed
the
feat/epub-slider-preview-percent
branch
2 times, most recently
from
August 23, 2026 11:32
f9ac0ed to
4d5d5c3
Compare
Remove preview bubble, slider now updates reading position in real-time during drag.
Use lodash throttle (150ms) to limit seek frequency during drag for smooth performance.
- Extract chapter resolution functions to dedicated helper file - Add comprehensive unit tests for all resolution strategies - Improve Strategy 4b with spine-index fallback for edge cases - Consolidate fallback logic to return first chapter consistently - Remove redundant fallback handling from App.vue
AlexAndBear
force-pushed
the
feat/epub-slider-preview-percent
branch
from
August 24, 2026 08:54
fbaf9e0 to
7790c80
Compare
kulmann
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the EPUB reader with multiple enhancements:
Chapter Resolution
compareDocumentPosition()for accurate chapter detectionProgress Slider UX
Code Quality & Stability
as anytype casts, added proper TypeScript definitions for epubjsprops.xpattern for cleaner codeRelated Issue
How Has This Been Tested?
pnpm test:unit --run packages/web-app-epub-reader(all 50 tests passing)pnpm check:all(types, lint, format, tests)Types of changes