Skip to content

enhancement(shares/jsoncs3): Shortcut migration on fresh system - #787

Merged
rhafer merged 1 commit into
opencloud-eu:mainfrom
rhafer:ocissue/3387
Aug 27, 2026
Merged

enhancement(shares/jsoncs3): Shortcut migration on fresh system#787
rhafer merged 1 commit into
opencloud-eu:mainfrom
rhafer:ocissue/3387

Conversation

@rhafer

@rhafer rhafer commented Aug 26, 2026

Copy link
Copy Markdown
Member

Avoid waiting in migrations on fresh systems. Some migrations are blocking the correct startup of the service until dependent services are up and running, we don't need this on a fresh system.

Fixes: opencloud-eu/opencloud#3392

Avoid waiting in migrations on fresh systems. Some migrations are blocking
the correct startup of the service until dependent services are up and
running, we don't need this on a fresh system.

Fixes: opencloud-eu/opencloud#3392
@rhafer
rhafer requested review from butonic and maki5 August 26, 2026 13:57
@rhafer rhafer self-assigned this Aug 26, 2026
@maki5

maki5 commented Aug 26, 2026

Copy link
Copy Markdown

some time ago I introduced this method https://github.com/rhafer/reva/blob/0d5e08ab4906528f24f2282f3a19f8d3aa258d36/pkg/share/manager/jsoncs3/jsoncs3.go#L371
for the same issue with test flakiness, but in case of the fresh system it seems to not be needed anymore with your change, can we consider using it in combination with your changes?

So basically to have it like:

  • on fresh system we mark migrations as applied
  • on non fresh we wait until migrations are actually applied

regarding just the introduced change LGTM

@rhafer

rhafer commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

some time ago I introduced this method https://github.com/rhafer/reva/blob/0d5e08ab4906528f24f2282f3a19f8d3aa258d36/pkg/share/manager/jsoncs3/jsoncs3.go#L371 for the same issue with test flakiness, but in case of the fresh system it seems to not be needed anymore with your change, can we consider using it in combination with your changes?

So basically to have it like:

* on fresh system we mark migrations as applied

* on non fresh we wait until migrations are actually applied

Hm, originally (when we implemented the first migration) the intention was to still be able to serve Read Requests (listing Share, getting an individual share), that is why we currently do not block until a migration has finished. For now, I think we can keep it that way. In the long run we might need to reconsider here.

@rhafer
rhafer merged commit 3482c30 into opencloud-eu:main Aug 27, 2026
19 of 20 checks passed
@openclouders openclouders mentioned this pull request Aug 27, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants