test: retry transient share-manager migration errors - #3392
Open
fredrikblau wants to merge 1 commit into
Open
Conversation
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The acceptance HTTP helper now retries the specific transient 500 response emitted while the share manager is migrating. Other 500 responses remain non-retryable.
Related Issue
Fixes #3387
Motivation and Context
The share manager intentionally rejects writes during migration with
share manager is currently migrating, please retry. Acceptance setup can hit this window while creating a space, causing a flaky test failure.Issue verification
Verified against the failure recorded in issue #3387: the acceptance test receives HTTP 500 while the share manager is migrating. The current vendored backend path confirms that this exact message is intentionally returned during migration. A live acceptance reproduction was not run because PHP and Composer are unavailable in the environment.
How Has This Been Tested?
git diff --checkTypes of changes
Checklist