Repository navigation
fix: start analytics for eligible public docs visits - #262
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Eligible public Docs visits do not start Google Analytics when the obsolete saved-choice gate has no valid grant.
User Impact
Public production visits now start analytics automatically unless DNT/GPC or existing private/public safety checks block them. All legacy analytics-choice records are ignored. No analytics notice, toggle or replacement UI is added; the existing Privacy policy link remains.
Why This Change Was Made
Remove the saved-record and regional startup dependencies while retaining the existing pageview owner, trusted restore handling, private-panel suspension, advertising denial and content-derived runtime identity. Historical evidence stays intact; no old choices are read, written or migrated. Hosting, stream settings and reporting metadata are unchanged by this patch.
Evidence
c28cb3384acbbab3fad4d1ee539fa1f638ade744cd7902bcac6c8174bc9997c5: 19 focused policy/navigation cases passed with all collection intercepted, including no record, old deny/grant, malformed/expired/inaccessible records, no region requests, DNT/GPC, private routes and delayed native transport.pageshow.persisted=true; ordinary pageshow/background updates do not add views, old peer records are ignored and GPC remains off.