Skip to content

fix: start analytics for eligible public docs visits - #262

Merged
hannesrudolph merged 1 commit into
mainfrom
fix/docs-public-analytics
Oct 3, 2026
Merged

hannesrudolph merged 1 commit into
mainfrom
fix/docs-public-analytics

Conversation

@hannesrudolph

Copy link
Copy Markdown
Member

What Problem This Solves

Eligible public Docs visits do not start Google Analytics when the obsolete saved-choice gate has no valid grant.

User Impact

Public production visits now start analytics automatically unless DNT/GPC or existing private/public safety checks block them. All legacy analytics-choice records are ignored. No analytics notice, toggle or replacement UI is added; the existing Privacy policy link remains.

Why This Change Was Made

Remove the saved-record and regional startup dependencies while retaining the existing pageview owner, trusted restore handling, private-panel suspension, advertising denial and content-derived runtime identity. Historical evidence stays intact; no old choices are read, written or migrated. Hosting, stream settings and reporting metadata are unchanged by this patch.

Evidence

  • Normal Node suite: 285 tests passed.
  • Fresh public SDK c28cb3384acbbab3fad4d1ee539fa1f638ade744cd7902bcac6c8174bc9997c5: 19 focused policy/navigation cases passed with all collection intercepted, including no record, old deny/grant, malformed/expired/inaccessible records, no region requests, DNT/GPC, private routes and delayed native transport.
  • Four full-Chromium lifecycle tests passed with trusted pageshow.persisted=true; ordinary pageshow/background updates do not add views, old peer records are ignored and GPC remains off.
  • Two actual-SDK private-panel cases passed, including the observed post-close batch and no private URL/input replay.
  • Generated 30-page preview remains excluded: active site runtime, zero analytics metadata, SDK requests and GA cookies.
  • Structured review: clean. Required CI runs before production merge. No synthetic GA traffic is forwarded.

@hannesrudolph
hannesrudolph requested a review from a team as a code owner October 3, 2026 23:30
@hannesrudolph
hannesrudolph merged commit 0da9249 into main Oct 3, 2026
5 checks passed
@hannesrudolph
hannesrudolph deleted the fix/docs-public-analytics branch October 3, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant