Repository navigation
fix: read nested docs URLs from canonical R2 objects - #260
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R2 currently stores nested docs HTML twice, under
/routeand/route/index.html. Make the Worker compatible with retaining only the canonical slashless object while preserving both public URLs.An explicit nested index request now reads the canonical object when its metadata identifies HTML, falling back to the legacy nested key when canonical HTML is absent. Requested URLs, content negotiation, caching policy, ETags and Markdown alternate links retain their existing behavior. Storage errors still propagate. This change does not omit or delete any object.
The tracked hosting runbook documents the two-stage rollout and rollback order. Duplicate retirement remains a separate change gated on the successful compatible Worker deployment, its version/commit/run receipt, and live route checks. After retirement, dual-key artifacts must be restored before rolling back to the old reader.
Validation:
No changes to analytics, consent, workflows, permissions, publication guards or the single-writer queue.