Repository navigation
fix: keep docs artifacts stable across content-only commits - #259
Merged
Merged
Conversation
| ${mountHomeHero.toString()} | ||
| ${createHomeGlimm.toString()} | ||
| const docsAnalytics=(${createDocsAnalytics.toString()})(()=>import(withBase(${JSON.stringify("/assets/" + webVitalsAssetName)}))); | ||
| const docsAnalytics=(${createDocsAnalytics.toString()})(()=>import(withBase(${JSON.stringify("/assets/" + webVitalsAssetName)})),docsRuntimeRelease); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A content-only docs commit changed the Git SHA stamped into every public HTML page, defeating R2's content diff even when article rendering was cached. A recent two-page update uploaded 31,117 objects. Stop that global churn by removing the per-page deployment SHA.
Analytics
releasenow identifies the executing JavaScript asjs-<12 hex>, derived from the complete emitted runtime before its identity is prepended. Serialized analytics/consent/config and hashed lazy-module paths participate. The full incoming commit is recorded separately asbuildCommitin the final R2 catalog; per-object hashes remain authoritative for retained content during partial uploads. The unused generation timestamp is also removed from the fallback search index.Consent, pageview ownership, private-surface handling, URLs, duplicate object compatibility, Pagefind coverage, upload ordering and deployment queue guards are unchanged. On the first rollout, a tab still using the previous attribute-based runtime reports its existing
localfallback after navigating to new HTML; no forced reload is introduced.Validation:
buildCommitand older out-of-scope object hashes.The first deployment changes the shell and requires a full HTML update. The upload reduction applies to subsequent content-only builds.