Skip to content

fix: restore installer functionality with PHP 8.4.1 and PHP 8.5 #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RussH merged 2 commits into from
Aug 26, 2026
Merged

fix: restore installer functionality with PHP 8.4.1 and PHP 8.5 #840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b1d4ab
fix: improve installer PHP and database compatibility
RussH Aug 26, 2026
919545c
chore: retrigger CI
RussH Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 22 additions & 14 deletions installwizard.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,28 +2,29 @@
include_once('constants.php');
include_once('config.php');

/* Version check before we include this. */
$phpVersion = phpversion();
$phpVersionParts = explode('.', $phpVersion);
if ($phpVersionParts[0] >= 5)
$minimumPHPVersion = '8.4.1';
$isSupportedPHPVersion = version_compare(
PHP_VERSION,
$minimumPHPVersion,
'>='
);

if ($isSupportedPHPVersion)
{
include_once(LEGACY_ROOT . '/lib/Template.php');
include_once(LEGACY_ROOT . '/lib/Session.php');
include_once(LEGACY_ROOT . '/lib/TemplateUtility.php');

@session_name(CATS_SESSION_NAME);
session_name(CATS_SESSION_NAME);
session_start();
}
else
{
$php4 = true;
}


$installLibURL = 'js/lib.js';
$installScriptURL = 'js/install.js';
$subModalScriptURL = 'js/submodal/subModal.js';
$installCSSURL = 'modules/install/install.css';
if (!isset($php4))
if ($isSupportedPHPVersion)
{
$installLibURL = call_user_func(array('TemplateUtility', 'getVersionedAssetURL'), $installLibURL);
$installScriptURL = call_user_func(array('TemplateUtility', 'getVersionedAssetURL'), $installScriptURL);
Expand All @@ -37,7 +38,7 @@
<head>
<title>OpenCATS - Installation Wizard Script</title>
<?php
if (!isset($php4) && isset($_SESSION['CATS']) && $_SESSION['CATS']->isLoggedIn())
if ($isSupportedPHPVersion && isset($_SESSION['CATS']) && $_SESSION['CATS']->isLoggedIn())
{
echo '<script type="text/javascript">CATSCsrfToken = ',
Template::escapeJs($_SESSION['CATS']->getCSRFToken()), ';</script>', "\n";
Expand Down Expand Up @@ -122,7 +123,14 @@
<br />
<span style="font-weight: bold;">Test Results</span>
<table class="test_output">
<tr class="fail"><td>PHP 5.0.0 or greater is required to run OpenCATS. Found version: <?php echo(phpversion()); ?>.</td></tr>
<tr class="fail">
<td>
OpenCATS requires PHP
<?php echo htmlspecialchars($minimumPHPVersion, ENT_QUOTES, 'UTF-8'); ?>
or newer. Found PHP
<?php echo htmlspecialchars(PHP_VERSION, ENT_QUOTES, 'UTF-8'); ?>.
</td>
</tr>
</table>
</div>
<div id="databaseConnectivity" style="display: none;">
Expand Down Expand Up @@ -466,7 +474,7 @@
<td>Please choose your time zone.</td>
</tr>
<tr>
<td style="padding-bottom: 10px;"><?php if (!isset($php4)) TemplateUtility::printTimeZoneSelect('timeZone', 'width: 420px;', '', OFFSET_GMT); ?></td>
<td style="padding-bottom: 10px;"><?php if ($isSupportedPHPVersion) TemplateUtility::printTimeZoneSelect('timeZone', 'width: 420px;', '', OFFSET_GMT); ?></td>
</tr>

<tr>
Expand Down Expand Up @@ -567,7 +575,7 @@
</table>

<script type="text/javascript">
<?php if (!isset($php4)): ?>
<?php if ($isSupportedPHPVersion): ?>
Installpage_populate('a=startInstall');
<?php else: ?>
setActiveStep(1);
Expand Down
18 changes: 17 additions & 1 deletion lib/CATSUtility.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,14 +168,30 @@ public static function changeConfigSetting($name, $value)
}

$result = @file_put_contents(
'config.php', implode("\n", $newconfig) . "\n"
'config.php',
implode("\n", $newconfig) . "\n"
);

if (!$result)
{
/* We either completely failed or wrote 0 bytes. */
return false;
}

/*
* Ensure subsequent requests see the updated configuration immediately
* when PHP OPcache is enabled.
*/
if (function_exists('opcache_invalidate'))
{
$configPath = realpath('config.php');

if ($configPath !== false)
{
opcache_invalidate($configPath, true);
}
}

return true;
}

Expand Down
Loading
Loading