Retain issue roots in explicit workspaceWrite policies#58
Open
danielmcauley wants to merge 3 commits intomainfrom
Open
Retain issue roots in explicit workspaceWrite policies#58danielmcauley wants to merge 3 commits intomainfrom
danielmcauley wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Ensure explicit
workspaceWritesandbox policies keep the current issue workspace writable while still allowing extra writable roots like linked-worktree.gitmetadata.TL;DR
Keep the issue workspace in explicit
workspaceWriteroots and update the launcher follow-up contract.Summary
workspaceWritepolicies at runtimeworkspaceWritesandbox policies unchangedAlternatives
cwdbeing writable implicitly, but current runtime/tests model explicitwritableRootsas authoritativeTest Plan
make -C elixir allcd /Users/dtm/code/symphony/elixir && mise exec -- mix test test/symphony_elixir/app_server_test.exs test/symphony_elixir/workspace_and_config_test.exs test/symphony_elixir/core_test.exscd /Users/dtm/code/symphony/elixir && mise exec -- mix specs.check