fix(types): make ResponseFunctionWebSearch.action optional#3481
Open
gautamkishore wants to merge 1 commit into
Open
fix(types): make ResponseFunctionWebSearch.action optional#3481gautamkishore wants to merge 1 commit into
gautamkishore wants to merge 1 commit into
Conversation
The API returns action=None for some completed web search calls, but the type declares action as required, causing attribute access (e.g. item.action.type) to break under strict typing. Make action Optional[Action] = None in both the stable and beta response types. Fixes openai#3179
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API returns
action=Nonefor some completed web search calls, but the response type declaresactionas required. This makes attribute access such asitem.action.typebreak under strict typing (and raises at runtime for users who assumed the field is always present).Make
actionOptional[Action] = Nonein both the stable and beta response types so the model matches the actual API payload.Fixes #3179