Repository navigation
fix: preserve nested handoff record boundaries - #5430
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed the parser/writer and regression coverage. LF-only splitting preserves embedded separators and structured JSON without fabricating transcript roles; legacy LF/CRLF records remain supported. No actionable findings.
Hosted CI at review: 2 skipped, 23 success. Static review only; no local code or tests run.
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed 108018b560b22916c232bfe8ef1372ddd98b80e1. No actionable findings. Splitting only on the writer's LF delimiter preserves embedded separators, message roles and structured JSON through repeated handoffs. Existing stripping retains legacy CRLF record handling. The added runner regression checks the final model input in both run modes.
Source-only review, including an independent pass; no candidate tests or builds ran here. Hosted CI and the required human reviews remain separate gates.
This pull request fixes nested handoff history parsing so embedded Unicode and control-character line separators remain part of their original message instead of becoming additional transcript records.
The parser now splits only on the LF delimiter emitted by the writer, preserving message roles and structured JSON content across repeated handoffs. Public APIs and the summary format remain unchanged, including support for previously generated summaries and legacy LF/CRLF records.