Repository navigation
bioframe.assign_view drop_unassigned drops all NaNs? #160
Description
If you have any other columns in the bedframe that might contain NaNs (bins from a cooler...), they will be also dropped - not what I expected.
Line 1886 in f0682ff
Activity
gfudenberg commentedon Dec 20, 2023
@Phlya -- couldn't tell from this, did you have a proposed behavior?
Phlya commentedon Dec 20, 2023
I guess it should drop on a subset of columns, to only actually drop unassigned intervals...
iqraakhtar09 commentedon Mar 12, 2024
The line of code you gave channels the DataFrame out_df to eliminate columns with any NaN values. In any case, it's conceivable that this activity could unintentionally drop lines with NaN values in different sections too, in addition to the particular segment being tended to. This conduct probably won't be what you expected, particularly to just drop lines in light of NaN values in a specific section. The code scrap doesn't unequivocally focus on a particular segment for NaN evacuation, so it could not completely live up to your assumptions in the event that you were wanting to hold lines with NaNs in different sections.
it's my personal thought correct me if i'm wrong