Feat/sharepoint non root sites - #97
Open
Fyrlex wants to merge 4 commits into
Open
Conversation
|
Anyhow @Fyrlex, knowing a bit how Tim likes the PR and quality code, I would sugges to delete that very long function description which is obviously AI generated. He totally dislikes that kind of PR's, so if you want your PR to be merged try to simplify the code a lot. It's a suggestion, hopefully this will be merged. |
Author
|
Okay, thanks for the clarification! I'll go clean up the description. |
Removed redundant comments and examples from the parse_sharepoint_source function.
|
We need this PR because it is not possible to get root access to our SharePoint site in GCC-High. We must get Cyber approval to access specific Teams shared folders within SharePoint (i.e. access is scoped). This PR in combination with #103 would be awesome for us! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for non-root site libraries, as previously, the library and documents could only be in the root site, and some entra applications may not have access to the root site too.
Refer to #83