Stabilize SamplingProfilerTest#3000
Open
zeitlinger wants to merge 1 commit into
Open
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to stabilize SamplingProfilerTest.testProfileTransaction() by removing a race between inferred work (aInferred(tracer)) and profiling session rollover, while keeping the existing assertions and behavior under test.
Changes:
- Adds an additional Awaitility wait intended to ensure the next profiling session has started after
aInferred(tracer)runs. - Keeps the existing span assertions unchanged while attempting to eliminate timing-related flakiness.
Comment on lines
+186
to
+188
| await() | ||
| .timeout(Duration.ofSeconds(10)) | ||
| .until(() -> setup.profiler.getProfilingSessions() > currentSession + 1); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aInferred(tracer)inSamplingProfilerTest.testProfileTransaction()Why
SamplingProfilerTest.testProfileTransaction()can observe the inferred work before the profiler has advanced into the next session, which makes the test flaky.Waiting for the next session keeps the existing behavior under test but avoids asserting too early.
Testing
GRADLE_USER_HOME=/tmp/gradle-home-otel-java-contrib ./gradlew --no-build-cache --no-configuration-cache :inferred-spans:test --tests io.opentelemetry.contrib.inferredspans.internal.SamplingProfilerTest