[fix] Handle None value for max_out_len parameter in HuggingFace model#2271
Open
Nexround wants to merge 1 commit intoopen-compass:mainfrom
Open
[fix] Handle None value for max_out_len parameter in HuggingFace model#2271Nexround wants to merge 1 commit intoopen-compass:mainfrom
Nexround wants to merge 1 commit intoopen-compass:mainfrom
Conversation
…ce model - Fix TypeError when max_out_len is None in arithmetic operations - Add proper None checking in _single_generate and _batch_generate methods - Use default values: 0 for max_length calculations, 512 for max_new_tokens - Update type annotations from int to Optional[int] for max_out_len parameter - Update docstrings to reflect the Optional[int] type change Fixes: TypeError: unsupported operand type(s) for 'int' and 'NoneType'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solving issue： #2270