Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR corrects the Cargo.toml configuration by removing the "luajit" feature from the base mlua dependency, making it truly optional. This ensures that luajit is only enabled when users explicitly request it via --features luajit, aligning with the feature flag definition in the [features] section.
Key Changes:
- Removed "luajit" from the default mlua dependency features, retaining only "module"
- The luajit feature flag in [features] section remains intact for opt-in usage
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| [dependencies] | ||
| mlua = { version = "0.9.9", features = ["luajit", "module"] } | ||
| mlua = { version = "0.9.9", features = [ "module"] } |
There was a problem hiding this comment.
There's an extra space before "module" in the features array. The spacing should be consistent with the formatting of other dependencies in the file.
Suggested change
| mlua = { version = "0.9.9", features = [ "module"] } | |
| mlua = { version = "0.9.9", features = ["module"] } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.