fix: remove luajit from default feature#6
Closed
boltlessengineer wants to merge 1 commit intooowl:masterfrom
Closed
fix: remove luajit from default feature#6boltlessengineer wants to merge 1 commit intooowl:masterfrom
luajit from default feature#6boltlessengineer wants to merge 1 commit intooowl:masterfrom
Conversation
this blocks `lua-reqwest` from being installed with `luarocks make` luarocks-build-rust-mlua adds detected lua version when running `cargo build` so we don't need to put default lua version. actually it will break when the environment's lua version doesn't match with `luajit` Signed-off-by: Seongmin Lee <git@boltless.me>
Owner
|
@boltlessengineer #9 merged your commit in another PR, thanks for your contribution. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this blocks
lua-reqwestfrom being installed withluarocks makeluarocks-build-rust-mluaadds detected lua version when runningcargo buildso we don't need to put default lua version.actually the
mlua-sysdependency build will break when the environment's lua version doesn't match withluajit