fix(menubar): use dashboard provider tab renames for card titles (rebase of #95)#105
Merged
Conversation
Settings → Providers gains Dashboard Tabs controls: drag-and-drop (or ↑/↓) reorder and custom tab names (emoji/unicode, max 48 chars). Preferences persist as dashboard_providers_order and dashboard_provider_labels. Also: - Provider brand icons before each tab name via real <img> tags (Safari- safe; dark theme inverts monochrome SVGs) - Compact header clock: Updated HH:MM:SS UTC+8 (IANA zone in tooltip) - Keep non-dashboard providers out of the tab-order list; refresh when API Integrations toggles; keep Last updated visible with long labels Co-authored-by: Grok 4.5 (high effort) <302482056+a-grok-build-bot[bot]@users.noreply.github.com>
Menubar hard-coded labels ignored dashboard_provider_labels (Settings tab rename). Resolve the same labels for every menubar card; multi-account Codex/MiniMax only append " - <account>" when more than one account. Co-authored-by: Grok 4.5 (high effort) <302482056+a-grok-build-bot[bot]@users.noreply.github.com>
# Conflicts: # internal/web/menubar_test.go # internal/web/static/icons/grok.svg # internal/web/static/icons/kimi.svg
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase/conflict-resolution of #95 (which subsumes #89) onto current main.
Original work by @yesme (commits by Haibara AI + Yesme preserved via merge).
Conflicts resolved:
icons/grok.svg,icons/kimi.svg: kept main'scurrentColor/1emvariants (from fix(menubar): use proper Grok and Kimi provider icons #91) which the CSS mask-image layer expects.menubar_test.go: kept all three tests - fix(menubar): use dashboard provider tab renames for card titles #95'sTestMenubarAccountLabel+TestBuildMenubarSnapshotUsesDashboardProviderLabelsand main'sTestBuildMenubarSnapshotGrokResetFields.Verified: build clean,
internal/web+internal/menubartests pass.Closes #95, closes #89.