perf(backoff): optimize linear backoff using closure#243
Open
Ayoub-Mabrouk wants to merge 1 commit intoonebeyond:masterfrom
Open
perf(backoff): optimize linear backoff using closure#243Ayoub-Mabrouk wants to merge 1 commit intoonebeyond:masterfrom
Ayoub-Mabrouk wants to merge 1 commit intoonebeyond:masterfrom
Conversation
- Remove lodash dependency for faster property access - Pre-calculate range in closure to avoid repeated subtraction on each call - Add early return optimization for constant values (min === max) - Use modern JS features (default parameters, arrow functions) The range calculation is moved from the hot path (next() function) to the closure scope, ensuring it's computed only once when the backoff function is created rather than on every invocation.
cressie176
approved these changes
Dec 10, 2025
Collaborator
cressie176
left a comment
cressie176
left a comment
There was a problem hiding this comment.
Thanks @Ayoub-Mabrouk
Author
Thanks! Also, PR #72 is approved and just needs your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove lodash dependency for faster property access
Pre-calculate range in closure to avoid repeated subtraction on each call
Add early return optimization for constant values (min === max)
-Use modern JS features (default parameters, arrow functions)
The range calculation is moved from the hot path (next() function) to
the closure scope, ensuring it's computed only once when the backoff
function is created rather than on every invocation