Add additional check for optional tables during init #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrspruit
force-pushed
the
fix_optional_invalid_ddi
branch
from
0be9363 to
18b3d0f
Compare
rwmcguir
previously approved these changes
Dec 18, 2025
nrspruit
force-pushed
the
fix_optional_invalid_ddi
branch
from
18b3d0f to
4b34a1b
Compare
Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
fix_optional_invalid_ddi
branch
from
4b34a1b to
8cab8a3
Compare
rwmcguir
approved these changes
Dec 19, 2025
Contributor
rwmcguir
left a comment
rwmcguir
left a comment
There was a problem hiding this comment.
Much better explanation. Thank you.
There was a problem hiding this comment.
Pull request overview
This pull request modifies the driver initialization logic to properly handle optional DDI (Device Driver Interface) tables. The change allows optional tables to fail gracefully without stopping the initialization process, while still failing fast on required table errors. This is achieved by ignoring return values from optional table loading functions and resetting the result to SUCCESS, ensuring the initialization continues to load remaining tables.
Key Changes:
- Modified initialization functions across multiple loader files to treat optional DDI tables differently from required ones
- Updated the template file to generate code that handles optional tables conditionally based on namespace
- Version bumped from 1.26.2 to 1.26.3
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| source/loader/zet_ldrddi.cpp | Added documentation and modified init function to ignore failures from optional DDI tables (Exp variants) |
| source/loader/zes_ldrddi.cpp | Added documentation and modified init function to ignore failures from optional DDI tables, removed error handling for specific optional tables |
| source/loader/zer_ldrddi.cpp | Added comprehensive documentation for the init function behavior |
| source/loader/ze_ldrddi.cpp | Added documentation and modified init function to ignore failures from optional DDI tables (Exp and RTAS variants) |
| scripts/templates/ldrddi.cpp.mako | Updated template to conditionally generate error handling based on whether table is optional |
| PRODUCT_GUID.txt | Updated version from 1.26.2 to 1.26.3 and refreshed GUID |
| CMakeLists.txt | Updated project version from 1.26.2 to 1.26.3 |
| CHANGELOG.md | Added v1.26.3 entry documenting the fix for optional DDI table handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.