Copy received RPC frames to avoid a shared file offset race - #546
Merged
Conversation
citrus-it
marked this pull request as draft
August 21, 2026 17:11
Linked image operations are carried out in child images by 'pkg remote' subprocesses, with requests and responses exchanged over a pipe by the transport in pkg.pipeutils. Each message is written to an unlinked temporary file whose descriptor is passed through the pipe with I_SENDFD; the receiver rewinds the descriptor and reads the message back. There is a race between the descriptor being used in the child and being closed in the parent. Fix that by copying the frame with positional reads.
citrus-it
marked this pull request as ready for review
August 21, 2026 19:59
hadfl
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.