Skip to content

minor fixes #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aggroot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

minor fixes #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion botasaurus_driver/core/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ def get(
# get the connection matching the new target_id from our inventory
connection:Connection = next(
filter(
lambda item: item._target.type_ == "page" and item.target_id == target_id,
lambda item: item._target.type_ == "page" and item._target.target_id == target_id,
self.targets,
)
)
Expand Down
1 change: 1 addition & 0 deletions botasaurus_driver/core/tab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ def __init__(
self.frames: typing.Dict[str, Frame] = {}
self._dom = None
self._window_id = None
self.is_closed = False

# removed to avoid runtime detection
# self.add_handler(
Expand Down