perf(reindex): reduce canonical embedding overhead - #1632
Draft
ohdearquant wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
note_embedding_textAPI compatible, add an internal borrowed form, and share oneArc<str>across multi-model spawned embedding tasks instead of cloning content per modelCloses #1338.
Test plan
cargo test --manifest-path crates/Cargo.toml --workspacecargo check --manifest-path crates/Cargo.toml --workspacecargo clippy --manifest-path crates/Cargo.toml --workspace --all-targets -- -D warningscargo fmt --manifest-path crates/Cargo.toml --all -- --checkRUSTDOCFLAGS=-Dwarnings cargo doc --manifest-path crates/Cargo.toml --workspace --no-depsAll commands passed at
83f827aeaff2ec4556ce340bb9e0976bc8835eb3on currentmain(a152ead3e577b8c01b03024687fdb66d94a00cac).ADR
n/a — this removes avoidable allocation and probe work without changing the embedding text, vector identity, transaction, or public API contracts. The vector API documentation is updated to describe the optimized DML path.
AI-assisted contribution checklist
Out of scope