feat(comm): add inbox long polling - #1631
Draft
ohdearquant wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wait_mslong-poll semantics tocomm.inboxwhile preserving the existing filtering and pagination response shapesCloses #1499.
Test plan
cargo test --manifest-path crates/Cargo.toml --workspacecargo check --manifest-path crates/Cargo.toml --workspacecargo clippy --manifest-path crates/Cargo.toml --workspace --all-targets -- -D warningscargo fmt --manifest-path crates/Cargo.toml --all -- --checkRUSTDOCFLAGS=-Dwarnings cargo doc --manifest-path crates/Cargo.toml --workspace --no-depsAll commands passed at
0a0c7e515b051f243eb1d3a73928c35bb2857527after rebasing onto currentmain(a152ead3e577b8c01b03024687fdb66d94a00cac).ADR
wait_mscontract and response-shape guaranteesAI-assisted contribution checklist
Out of scope