fix(brain): make automatic feedback explicit and target-safe - #1630
Draft
ohdearquant wants to merge 1 commit into
Draft
fix(brain): make automatic feedback explicit and target-safe#1630ohdearquant wants to merge 1 commit into
ohdearquant wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
originating_verb, while keeping the canonical stored event verb stable for replay and historical queriesbrain.feedback,brain.auto_feedback, and the deprecatedbrain.emitpath can be measured independentlybrain.auto_feedback.signalan explicit abstention that writes no feedback event and performs no posterior updateresults[].id, use that selected result for target and serve attribution, and retain the full result set only as candidate contextWhy these issues belong together
#1587 is the observability prerequisite for #1588: automatic-feedback behavior cannot be evaluated if its emitted events remain indistinguishable from direct feedback. This PR first preserves the originating path on the event, then removes the rank-first positive-feedback loop behind a target-safe contract that can be measured by that provenance.
Verification
All checks passed at exact commit
3f3687b01bbf8b0740d71694f0ff2bbd27cd92b6:cargo test --manifest-path crates/Cargo.toml --workspacecargo check --manifest-path crates/Cargo.toml --workspacecargo clippy --manifest-path crates/Cargo.toml --workspace --all-targets -- -D warningscargo fmt --manifest-path crates/Cargo.toml --all -- --checkRUSTDOCFLAGS=-Dwarnings cargo doc --manifest-path crates/Cargo.toml --workspace --no-depsAn independent review found no actionable issues.
Closes #1587
Closes #1588