Skip to content

fix(git): report per-source digest coverage - #1622

Draft
ohdearquant wants to merge 1 commit into
mainfrom
codex/git-digest-source-coverage
Draft

fix(git): report per-source digest coverage#1622
ohdearquant wants to merge 1 commit into
mainfrom
codex/git-digest-source-coverage

Conversation

@ohdearquant

Copy link
Copy Markdown
Owner

Summary

  • make git.digest report stable machine-readable outcome objects for the issue and pull-request sources, including status, reason, and count
  • reserve gh_available for the GitHub CLI presence probe and report remote compatibility, command failures, budget exhaustion, and caller opt-out through the per-source outcomes
  • preserve the existing human warnings, item budget, cursor semantics, and aggregate done meaning while documenting the additive contract in ADR-088 and the public API guide

Source outcomes

  • ingested: the source command succeeded, including a valid empty result
  • skipped: not_requested, remote_not_github, gh_cli_absent, or budget_exhausted
  • failed: the source command failed with gh_error

The two source objects are independent, so partial coverage no longer has to be inferred from gh_available, warnings, or a zero aggregate count.

Validation

  • cargo test --manifest-path crates/Cargo.toml -p khive-pack-git (216 unit tests and 57 acceptance tests)
  • cargo test --manifest-path crates/Cargo.toml --workspace
  • cargo check --manifest-path crates/Cargo.toml --workspace
  • cargo clippy --manifest-path crates/Cargo.toml --workspace --all-targets -- -D warnings
  • cargo fmt --manifest-path crates/Cargo.toml --all -- --check
  • RUSTDOCFLAGS=-Dwarnings cargo doc --manifest-path crates/Cargo.toml --workspace --no-deps

Closes #1617.

AI-assisted contribution: Codex prepared this change and PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

git.digest: per-source ingest coverage is not machine-readable; gh_available conflates CLI presence with remote usability

1 participant