Open
Conversation
IMGUI_TEST_ENGINE_ENABLE_STD_FUNCTION required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work depends on:
ocornut/imgui@master...xuboying:imgui:feature-cjk-wrap
As discussed in ocornut/imgui#8990, this PR updates the ImGui test suite to support studying CJK word‑wrapping behavior.
Added test cases
widgets_text_wrapped_cjk_legacy_headlesswidgets_text_wrapped_cjk_zh_cn_mixed_char_with_pronunciation_mark_not_allow_at_headwidgets_text_wrapped_cjk_zh_cn_mixed_char_with_pronunciation_mark_not_allow_at_tailwidgets_text_wrapped_cjk_zh_cn_mixed_with_englishHelper
cjk_wrap_test_helper(requiresIMGUI_TEST_ENGINE_ENABLE_STD_FUNCTION)Notes
The CJK wrapping rules are generally straightforward, with the main complexity coming from handling pronunciation marks.
In the screenshots below, the yellow line indicates the wrap width, and the green rectangle shows the actual wrapped region.
By the way, I added a HiDPI manifest to my local build to avoid blurry text (ideally every Win32 application should ship with one by default). As expected, the text became quite small afterward, so I set the Font DPI Scale to 2, which matches my monitor. However, this value resets every time the test engine closes — possibly a TE bug.