Skip to content

Privileged LDAP (again) - #169

Open
ja5087 wants to merge 2 commits into
ocf:masterfrom
ja5087:privileged_ldap
Open

ja5087 wants to merge 2 commits into
ocf:masterfrom
ja5087:privileged_ldap

Conversation

@ja5087

@ja5087 ja5087 commented Apr 20, 2019

Copy link
Copy Markdown
Member

Last time we tried to merge this (see #157) the prerequisite ucbldap.passwd was not present in ocfweb, dev-ocfweb etc.

I've rolled back all the changes I made to the tests. Once the password file has been added to the puppet configs for ocfweb and Jenkins, this PR should be good for merging.

@cg505

cg505 commented Apr 21, 2019

Copy link
Copy Markdown
Member

I think you want to take another look at this. ocflib/account/search.py was broken by the master merge. The master merge also included the revert of the last version, so you may need to include a commit reverting that as well. (For instance, ocflib/infra/ldap.py in this PR does not contain the ldap_ucb_privileged function. git revert bec763573a74fad348e6c43254009bb79a1b472c may do what you want, but you should manually verify that.)

@ja5087

ja5087 commented Apr 21, 2019

Copy link
Copy Markdown
Member Author

well this is not ideal

@cg505

cg505 commented Apr 22, 2019

Copy link
Copy Markdown
Member

@ja5087 I added a commit. I think now you will just need to fix the tests to account for the different functions.

Sorry for all the trouble. Reverting merges in git is known to be annoying and hard to handle.

@kpengboy

Copy link
Copy Markdown
Member

What's the current status of this?

@ja5087

ja5087 commented Dec 8, 2019

Copy link
Copy Markdown
Member Author

It's been stalled for a while, but I do have a better understanding of the system now and could get back on it soon

@emmatyping

Copy link
Copy Markdown
Member

@ja5087 would you have time to re-base and bring this over the finish line at some point? Would love to see this landed!

@axmmisaka

Copy link
Copy Markdown

I can potentially finish this at some point if I still have time, but I'm unsure if password is used frequently as what I encountered mostly is that we use Kerberos ticket to auth???

@kafu-densha
kafu-densha force-pushed the master branch 3 times, most recently from ebcb5ce to c42aaad Compare August 16, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants