Skip to content

Comments

Add 'smtp_required' option to Python SDK hosted auth#458

Merged
pengfeiye merged 2 commits intomainfrom
TW-4629-add-smtp-required-option-to-python-sdk-hosted-auth
Feb 19, 2026
Merged

Add 'smtp_required' option to Python SDK hosted auth#458
pengfeiye merged 2 commits intomainfrom
TW-4629-add-smtp-required-option-to-python-sdk-hosted-auth

Conversation

@pengfeiye
Copy link
Contributor

@pengfeiye pengfeiye commented Feb 17, 2026

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.


Note

Low Risk
Small, additive change limited to auth URL query construction and typed config; main risk is unintended mutation/parameter differences in generated URLs.

Overview
Adds an optional smtp_required flag to hosted authentication URL configuration, allowing IMAP flows to force SMTP settings entry by emitting options=smtp_required in the generated query string.

Updates _build_query (and PKCE variant) to translate and strip the flag from URL params, adds targeted unit tests for true/false/omitted cases, and documents the new option in the changelog and config docstring.

Written by Cursor Bugbot for commit 55e7b5f. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@pengfeiye pengfeiye merged commit c04c3d8 into main Feb 19, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants